-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry #404
Add telemetry #404
Conversation
import {diff} from './diff' | ||
import {EscapeHatches, getEscapeHatches} from './get-escape-hatches' | ||
|
||
interface TelemetryPayload { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quesabe should be type
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've configured the consistent-type-definitions
rule to require interfaces
, since JSII does not work with type
for exported members.
This one is not exported and thus can be converted to type
. However it would require either to disable the eslint rule per line or completely switch it off for the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quesabe do you mean that the aslant rule in the repo requires interface
s instead of type
s? If so, then I'm ok with interface. Just wanted it to stay consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conversation if what I'm saying above is correct.
b599682
to
9b9ed74
Compare
9b9ed74
to
571bbdd
Compare
Closes PLA-263.
A common module for telemetry defines:
node-fetch
package since we claim Node16 support;