Skip to content

Commit

Permalink
Merge pull request #12 from ottogroup/feature-document-backward-incom…
Browse files Browse the repository at this point in the history
…patiblity

Add note about backward incompatiblity.
  • Loading branch information
alattner committed Jun 24, 2015
2 parents d0d4694 + c1be442 commit 1474787
Showing 1 changed file with 30 additions and 1 deletion.
31 changes: 30 additions & 1 deletion docs/user/upgrading.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Upgrading
:local:


Upgrading the database
======================

Changes between Palladium versions may require upgrading the model
database or similar. These upgrades are handled automatically by the
``pld-upgrade`` script. Before running the script, make sure you've
Expand All @@ -28,7 +31,7 @@ you only want to run the upgrade steps between version ``0.9`` and
pld-upgrade --from=0.9.1 --to=1.0
Upgrading the Database persister from version 0.9.1 to 1.0
==========================================================
----------------------------------------------------------

Users of :class:`palladium.persistence.Database` that are upgrading
from version 0.9.1 to a more recent version (maybe 1.0) are required
Expand All @@ -37,3 +40,29 @@ to invoke pld-upgrade with an explicit ``--from`` version like so:
.. code-block:: bash
pld-upgrade --from=0.9.1
Backward incompatibilities in code
==================================

The development team makes an effort to try and keep the API backward
compatibility, and only gradually deprecate old code where necessary.
However, some changes between major Palladium versions still introduce
backward incompatibilities and potentially require you to update your
Palladium plug-ins.

Breaking changes between 0.9.1. and 1.0
---------------------------------------

Backward incompatible changes between 0.9.1. and 1.0 are of concern
only to users who have implemented their own version of
:class:`palladium.server.PredictService`.

:meth:`palladium.server.PredictService.sample_from_request` has been
replaced by the very similar
:meth:`~palladium.server.PredictService.sample_from_data`. The new
method now accepts a ``data`` argument instead of ``request``.
``data`` is the equivalent of the former ``request.args``. Similarly,
:meth:`palladium.server.PredictService.params_from_request` has been
replaced by :meth:`~palladium.server.PredictService.params_from_data`.
The latter now also accepts ``data`` instead of ``request``, which
again is the equivalent of the former ``request.data``.

0 comments on commit 1474787

Please sign in to comment.