Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In PredictService, allow handling data as a 1d array instead of 2d #86

Merged
merged 1 commit into from
May 29, 2018

Conversation

dnouri
Copy link
Collaborator

@dnouri dnouri commented May 28, 2018

When working with text, scikit-learn and others will sometimes expect the
input to be a 1d array of strings rather than a 2d array. Setting the
new unwrap_sample to true will use this representation.

@dnouri dnouri force-pushed the feature/predict-service-unwrap-for-text branch from 45af61b to 059ef5f Compare May 28, 2018 16:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 059ef5f on feature/predict-service-unwrap-for-text into 1909827 on develop.

@coveralls
Copy link

coveralls commented May 28, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 8df98ee on feature/predict-service-unwrap-for-text into 8fb6b3d on develop.

dnouri added a commit to skorch-dev/skorch that referenced this pull request May 28, 2018
This is in preparation of a tutorial on how to use Skorch together
with Palladium.  A configuration that can be used to serve the model
is already included, but as of now requires Palladium PR #86 to
function: ottogroup/palladium#86
@dnouri dnouri force-pushed the feature/predict-service-unwrap-for-text branch from 059ef5f to 1833bbf Compare May 29, 2018 14:33
When working with text, scikit-learn and others will sometimes expect
the input to be a 1d array of strings rather than a 2d array.  Setting
the new *unwrap_sample* to true will use this representation.
@dnouri dnouri force-pushed the feature/predict-service-unwrap-for-text branch from 1833bbf to 8df98ee Compare May 29, 2018 14:44
@alattner alattner merged commit 68bc9ab into develop May 29, 2018
@alattner alattner deleted the feature/predict-service-unwrap-for-text branch May 29, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants