Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add start command (#72) #76

Merged
merged 1 commit into from
May 20, 2020

Conversation

mprey
Copy link
Contributor

@mprey mprey commented Dec 9, 2019

Closes #72

Notes:

  • HyperKit cannot support a start command as we are only managing the process PID to control the state of the VM
  • start on HyperKit would be the equivalent of run, but since commands/run.js has extra functionality, throw an error instead of trying to duplicate code in commands/start.js
  • KVM start will not work after slim stop <vm> -p kvm since this uses destroy instead of shutdown. See Providing acpid support for KVM #75 to see remedy. KVM start will only work after unexpected shutdown

@ssmirr
Copy link
Contributor

ssmirr commented Dec 10, 2019

Thanks for the PR @mprey! 👍

This looks good, but lets make a decision in #75 before we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add slim start [vm-name] command
3 participants