Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart more slowly #2145

Merged
merged 1 commit into from Aug 2, 2015
Merged

Restart more slowly #2145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions config/deploy.rb
View file
Open in desktop
Expand Up @@ -64,8 +64,15 @@
# overwrite default capistrano deploy tasks
namespace :deploy do
desc "Restart the unicorns"
task :restart, :roles => :app do
run "/home/ao3app/bin/unicorns_reload"
task :restart do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary spacing detected.

find_servers(:roles => :app).each do |server|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

puts "restart on #{server.host}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not write to stdout. Use Rails' logger if you want to log.

run "/home/ao3app/bin/unicorns_reload"
unless servers.last == server
puts "Sleeping for 15 seconds #{server.host}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not write to stdout. Use Rails' logger if you want to log.

Really this needs to got to stdout

sleep(15)
end
end
end

desc "Restart the resque workers"
Expand Down