AO3-4345 Error page markup and styling corrections #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,23 +28,19 @@ http://otwcode.github.com/docs/front_end_coding/patterns/supertypes | |||
| padding: 2em 7.5em 3.5em; | |||
| } | |||
|
|
|||
| #main.error, #main.slow, #main.maintenance { | |||
| #main.errors { | |||
There was a problem hiding this comment.
The .error class controls the styling for our flash messages, which have borders, font colors, and shadows. Changing the name we use on our error pages eliminates the need for these styles (besides, we usually use plurals in the #main div).
zz9pzza
added a commit
that referenced
this pull request
Oct 15, 2015
AO3-4345 Error page markup and styling corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://otwarchive.atlassian.net/browse/AO3-4345
A line of text on our 404 pages was the wrong color in the Reversi skin due to some wonky HTML on the page. This corrects the HTML on that page and all the other dynamic error pages, and it also makes the error page markup the same for both the dynamic and static pages.