AO3-4468 Fixing TODOs on admin news post tests #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little confused about the point of the comment -- is it just a reminder to fix https://otwarchive.atlassian.net/browse/AO3-3685? If so, it might help to reference the issue number. |
|
Hmm, that's odd - that issue is saying "admin-whoever" is not a link, whereas it was when I tested. So I don't think that issue is actually an issue, based on my testing, though it would be better still if it was clearer. |
|
That's definitely odd -- I tried it just now, and it wasn't a link: http://test.archiveofourown.org/comments/5203993 (on http://test.archiveofourown.org/admin_posts/290?page=2&show_comments=true&view_full_work=false) |
|
Okay, updated comment accordingly. |
sarken
added a commit
that referenced
this pull request
Feb 3, 2016
AO3-4468 Fixing TODOs on admin news post tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://otwarchive.atlassian.net/browse/AO3-4468
The automated tests for admins posting news posts and commenting on them had a TODO - fix it by adding a clearer comment. The test for this is already expanded in a separate pull req.