AO3-4475 Fix TODOs in comment test #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| n_comments.to_i.times do |i| | ||
| step %{I am logged in as a random user} | ||
| step %{I post the comment "Bla bla" on the work "#{title}"} | ||
| visit work_url(work) | ||
| fill_in("comment[content]", :with => "Bla bla") |
| Then I should see "Comment was successfully updated" | ||
| And I should see "Actually, I meant something different" | ||
| And I should not see "Mistaken comment" | ||
| And I should see "EST" within ".comment .posted" |
There was a problem hiding this comment.
I am confused / worried about hardcoding this timezone here. Since @cesy is travelling, if anyone else can explain if/why it's safe to do so that would also be good!
There was a problem hiding this comment.
It's the default timezone in our Archive config file. Would it be better to make it a reference to that config?
zz9pzza
added
Awaiting Review
Reviewed: Action Needed
and removed
Awaiting Review
labels
sarken
added a commit
that referenced
this pull request
Mar 3, 2016
AO3-4475 Fix TODOs in comment test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://otwarchive.atlassian.net/browse/AO3-4475
Our automated test for comment pagination, threading and editing has some TODOs. Fix them.
The last test here is a pretty slow one, given that it needs a lot of comments, so I've also done my best to speed it up.