AO3-4702 Test autocomplete #2601

zz9pzza · 2016-10-27T23:47:14Z

Pull Request Checklist

Have you read How to write the perfect pull request?
Have you read through the contributor guidelines?
Have you added tests for any changed functionality?
Have you added the JIRA issue number as the first thing in your pull request title (eg: AO3-1234 Fix thing)
Have you updated the JIRA issue with the information below?

Issue

https://otwarchive.atlassian.net/browse/AO3-4702

Purpose

Test the autocomplete.

Testing

No manual testing required.

sarken · 2016-10-28T02:43:22Z

features/step_definitions/web_steps.rb

+ find(selector).native.send_keys(contents)
+ #sleep 5
+ #puts page.evaluate_script( 'document.documentElement.innerHTML' )
+ puts find(:css , 'div.autocomplete.dropdown', :wait=> 20 , :text => 'uby' ).text


For what it's worth, the text that autocomplete generates is actually inside a li inside a ul inside the div:

<div class="autocomplete dropdown" style="position: absolute; z-index: 999; display: none;"> <ul role="listbox" aria-activedescendant="ui-active-menuitem" style="display: block;"> <li role="option" class="odd"><b>Te</b>sting</li>

So I don't think looking for it in the div will work -- I think you'll have to look at the list items themselves with something like div.autocomplete li

bingeling · 2016-10-30T18:57:01Z

features/tags_and_wrangling/tag_wrangling_fandoms.feature

@@ -2,7 +2,7 @@

 Feature: Tag Wrangling - Fandoms

-Scenario: fandoms wrangling - syns, mergers, autocompletes, metatags
+Scenario: fandoms wrangling - syns, mergerss, metatags


I think this is a typo and should be "mergers", not "mergerss"

bingeling · 2016-10-30T18:59:05Z

features/tags_and_wrangling/tag_wrangling_fandoms.feature

+    And I am logged in as "Enigel" with password "wrangulate!"
+    When I go to the "Ruby (SU)" tag page
+     And I follow "Edit"
+     And I type in "ul.autocomplete" with "Ruby"


"ul.autocomplete" is the container, "ul.autocomplete input" is the form field to type into

…O3-4702

houndci-bot · 2016-10-31T22:30:07Z

features/step_definitions/web_steps.rb

@@ -298,6 +320,7 @@ def with_scope(locator)
  sleep 120
 end

+


Extra blank line detected.

houndci-bot · 2016-10-31T22:30:08Z

features/step_definitions/web_steps.rb

+  # resist the temptation. You should only verify outcome that is observable for
+  # the user (or external system) and databases usually are not.
+  result = false
+  (1..20).each do 


Use Integer#times for a simple loop which iterates a fixed number of times.

houndci-bot · 2016-10-31T22:30:08Z

features/step_definitions/web_steps.rb

@@ -33,6 +33,11 @@ def with_scope(locator)
  page.driver.browser.url_whitelist = ['http://127.0.0.1']
 end

+When /^I type in "([^"]*)" with "([^"]*)"$/ do |selector,contents|
+ Rails.cache.delete('/v1/autocomplete_hack/last_result')


Use 2 (not 1) spaces for indentation.

houndci-bot · 2016-10-31T22:30:08Z

features/step_definitions/web_steps.rb

@@ -33,6 +33,11 @@ def with_scope(locator)
  page.driver.browser.url_whitelist = ['http://127.0.0.1']
 end

+When /^I type in "([^"]*)" with "([^"]*)"$/ do |selector,contents|


Space missing after comma.

houndci-bot · 2016-10-31T22:30:08Z

app/controllers/autocomplete_controller.rb

@@ -36,7 +36,9 @@ def pseud
  private
    def tag_output(search_param, tag_type)
      tags = Tag.autocomplete_lookup(:search_param => search_param, :autocomplete_prefix => "autocomplete_tag_#{tag_type}")
-      render_output tags.map {|r| Tag.name_from_autocomplete(r)}
+      output = tags.map {|r| Tag.name_from_autocomplete(r)}
+      Rails.cache.write('/v1/autocomplete_hack/last_result', output ) if ENV["RAILS_ENV"] == "test"


Space inside parentheses detected.

houndci-bot · 2016-10-31T22:30:09Z

app/controllers/autocomplete_controller.rb

@@ -36,7 +36,9 @@ def pseud
  private
    def tag_output(search_param, tag_type)
      tags = Tag.autocomplete_lookup(:search_param => search_param, :autocomplete_prefix => "autocomplete_tag_#{tag_type}")
-      render_output tags.map {|r| Tag.name_from_autocomplete(r)}
+      output = tags.map {|r| Tag.name_from_autocomplete(r)}


Space between { and | missing.
Space missing inside }.

sarken · 2016-11-10T23:30:30Z

Is this still a WIP?

sarken · 2016-11-26T06:39:01Z

This has conflicts and will need to be updated, but it's still marked "WIP," so I'm not sure if it's done.

houndci-bot · 2016-11-26T06:47:53Z

features/step_definitions/web_steps.rb

@@ -303,6 +325,7 @@ def with_scope(locator)
  sleep 120
 end

+


Extra blank line detected.

houndci-bot · 2016-11-26T06:47:54Z

features/step_definitions/web_steps.rb

+  # resist the temptation. You should only verify outcome that is observable for
+  # the user (or external system) and databases usually are not.
+  result = false
+  (1..20).each do 


Use Integer#times for a simple loop which iterates a fixed number of times.

houndci-bot · 2016-11-26T06:47:54Z

features/step_definitions/web_steps.rb

@@ -33,6 +33,11 @@ def with_scope(locator)
  page.driver.browser.url_whitelist = ['http://127.0.0.1']
 end

+When /^I type in "([^"]*)" with "([^"]*)"$/ do |selector,contents|
+ Rails.cache.delete('/v1/autocomplete_hack/last_result')


Use 2 (not 1) spaces for indentation.

houndci-bot · 2016-11-26T06:47:54Z

features/step_definitions/web_steps.rb

@@ -33,6 +33,11 @@ def with_scope(locator)
  page.driver.browser.url_whitelist = ['http://127.0.0.1']
 end

+When /^I type in "([^"]*)" with "([^"]*)"$/ do |selector,contents|


Space missing after comma.

houndci-bot · 2016-11-26T06:47:54Z

app/controllers/autocomplete_controller.rb

@@ -36,7 +36,9 @@ def pseud
  private
    def tag_output(search_param, tag_type)
      tags = Tag.autocomplete_lookup(:search_param => search_param, :autocomplete_prefix => "autocomplete_tag_#{tag_type}")
-      render_output tags.map {|r| Tag.name_from_autocomplete(r)}
+      output = tags.map {|r| Tag.name_from_autocomplete(r)}
+      Rails.cache.write('/v1/autocomplete_hack/last_result', output ) if ENV["RAILS_ENV"] == "test"


Space inside parentheses detected.

houndci-bot · 2016-11-26T06:47:54Z

app/controllers/autocomplete_controller.rb

@@ -36,7 +36,9 @@ def pseud
  private
    def tag_output(search_param, tag_type)
      tags = Tag.autocomplete_lookup(:search_param => search_param, :autocomplete_prefix => "autocomplete_tag_#{tag_type}")
-      render_output tags.map {|r| Tag.name_from_autocomplete(r)}
+      output = tags.map {|r| Tag.name_from_autocomplete(r)}


Space between { and | missing.
Space missing inside }.

shalott · 2016-11-28T18:57:50Z

I hate to say this, but I think this is fundamentally a bad idea as well as a hack. You are not actually testing the autocomplete, you're just creating the illusion of having tested it, which IMO is worse because it gives us false confidence.

If you've got the testing-with-javascript working, I suspect the issue is you were not looking at the right field -- the autocomplete javascript does a thing where it replaces one div with another which holds the actual results. I actually wrote code that I think was working to access it but never managed to finish implementing the PR involved, I will dig the code out if you want?

zz9pzza · 2016-11-30T23:21:13Z

I had high hopes for:

assert page.should have_css('div.autocomplete.dropdown', :text => answer)

but no

sarken · 2017-04-24T22:44:15Z

Closing in favor of #2877

The autocomplete fires, but I have trouble finding the text

eb73392

sarken reviewed Oct 28, 2016

View reviewed changes

zz9pzza added 2 commits October 28, 2016 17:00

This fails with the scenario rather than a step

c1685c4

Fix typo

bbe2d48

bingeling reviewed Oct 30, 2016

View reviewed changes

zz9pzza added 2 commits October 31, 2016 22:17

Merge branch 'master' of https://github.com/otwcode/otwarchive into A…

2b8702b

…O3-4702

Remove last check as it should not be in the auto complete list

7365d89

houndci-bot reviewed Oct 31, 2016

View reviewed changes

features/step_definitions/web_steps.rb

@@ -298,6 +320,7 @@ def with_scope(locator)

sleep 120

end

Copy link

houndci-bot Oct 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

houndci-bot reviewed Oct 31, 2016

View reviewed changes

Fix merge conflict

930c626

houndci-bot reviewed Nov 26, 2016

View reviewed changes

features/step_definitions/web_steps.rb

@@ -303,6 +325,7 @@ def with_scope(locator)

sleep 120

end

Copy link

houndci-bot Nov 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line detected.

houndci-bot reviewed Nov 26, 2016

View reviewed changes

zz9pzza changed the title ~~[WIP} AO3-4702 The autocomplete work~~ [WIP] AO3-4702 The autocomplete work Nov 26, 2016

zz9pzza changed the title ~~[WIP] AO3-4702 The autocomplete work~~ AO3-4702 The autocomplete work Nov 26, 2016

zz9pzza changed the title ~~AO3-4702 The autocomplete work~~ AO3-4702 Test autocomplete Nov 26, 2016

zz9pzza added Awaiting Review Priority: High labels Nov 26, 2016

Listen to the hound

56309e8

shalott added Reviewed: Action Needed and removed Awaiting Review labels Nov 28, 2016

zz9pzza removed the Priority: High label Jan 29, 2017

sarken closed this Apr 24, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AO3-4702 Test autocomplete #2601

AO3-4702 Test autocomplete #2601

zz9pzza commented Oct 27, 2016 •

edited

sarken Oct 28, 2016

bingeling Oct 30, 2016

bingeling Oct 30, 2016

houndci-bot Oct 31, 2016

houndci-bot Oct 31, 2016

houndci-bot Oct 31, 2016

houndci-bot Oct 31, 2016

houndci-bot Oct 31, 2016

houndci-bot Oct 31, 2016

sarken commented Nov 10, 2016

sarken commented Nov 26, 2016

houndci-bot Nov 26, 2016

houndci-bot Nov 26, 2016

houndci-bot Nov 26, 2016

houndci-bot Nov 26, 2016

houndci-bot Nov 26, 2016

houndci-bot Nov 26, 2016

shalott commented Nov 28, 2016

zz9pzza commented Nov 30, 2016

sarken commented Apr 24, 2017

AO3-4702 Test autocomplete #2601

AO3-4702 Test autocomplete #2601

Conversation

zz9pzza commented Oct 27, 2016 • edited

Pull Request Checklist

Issue

Purpose

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarken commented Nov 10, 2016

sarken commented Nov 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shalott commented Nov 28, 2016

zz9pzza commented Nov 30, 2016

sarken commented Apr 24, 2017

zz9pzza commented Oct 27, 2016 •

edited