AO3-4719 Refactor work search tests #2615
Conversation
| @@ -93,6 +93,18 @@ | |||
|
|
|||
| ### GIVEN | |||
|
|
|||
| Given(/^I have the Battle set loaded$/) do | |||
There was a problem hiding this comment.
An alternative would have been to use a Background section in the Cucumber scenario, which would then make it clearer what has been loaded before each test for users who only read the feature file (if we ever get any "business" "stakeholders" to do that!). But as the Cucumber documentation recommends not having Backgrounds longer than 4 lines, and nobody who isn't a coder looks at them, I think this is probably the right approach here.
| get :index, tag_id: @fandom.name | ||
| expect(assigns(:works).items).to include(@work) | ||
| expect(assigns(:works).items).not_to include(@work2) | ||
| end | ||
|
|
||
| xit "should show restricted works to logged-in users" do | ||
| it "should show restricted works to logged-in users" do |
There was a problem hiding this comment.
This is the test that breaks the import specs (I enabled it locally to check and the story_parser tests failed). I suspect it's due to the fake_login method which amongst other things, stubs the current_user call to return a user who isn't an archivist, and then doesn't reset normal calls afterwards. I think this test needs to clean up after itself.
sarken
changed the title
|
@ariana-paris @sarken it is unclear if you want me to move this to Background ? |
|
No, the Background thing was just a suggestion. I only requested changes it because you needed to fix the test, which I guess you did by putting it back the way it was. Something for another day! |
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-4719
Purpose
This just refactors the works searching, there will be another pull along in a bit to actually add coverage.
Testing
No manual testing