Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-4883 Update selenium-webdriver #2768

Merged
merged 1 commit into from
Mar 2, 2017
Merged

AO3-4883 Update selenium-webdriver #2768

merged 1 commit into from
Mar 2, 2017

Conversation

zz9pzza
Copy link
Contributor

@zz9pzza zz9pzza commented Mar 2, 2017

Issue

https://otwarchive.atlassian.net/browse/AO3-4883

Purpose

Ruby zip needs updating.
it is included by selenium-webdriver which is only used in test, no manual testing required.

Testing

The gem is only used in test, no manual testing required.

@zz9pzza zz9pzza changed the title Update selenium-webdriver AO3-4883 Update selenium-webdriver Mar 2, 2017
sarken
sarken approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, this should be ready to go 👍

@sarken sarken merged commit 1e97d63 into otwcode:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarken sarken sarken approved these changes

Assignees
No one assigned
Labels
Gem Updates Priority: High Reviewed: Ready to Merge
Projects
None yet
Milestone
No milestone
2 participants
@zz9pzza @sarken