AO3-4808 Display an error if fandom is removed when editing tags #2808
Conversation
sarken
added
Priority: High - Broken on Test
app/controllers/works_controller.rb
Outdated
| @@ -455,6 +455,7 @@ def update | |||
| end | |||
|
|
|||
| def update_tags | |||
| set_work_tag_error_messages | |||
There was a problem hiding this comment.
The warning will be shown if I remove all fandom tags then hit "Cancel".
There was a problem hiding this comment.
Thank you -- good catch! Taking the Ready to Merge label off and putting Needs Coder Action on.
ariana-paris
force-pushed
the
AO3-4808-fandom-500-edit-tags
branch
from
892cd41
to
205da81
Compare
| flash[:notice] = ts('Tags were successfully updated.') | ||
| redirect_to(@work) | ||
| else | ||
| if @work.has_required_tags? && @work.invalid_tags.blank? |
There was a problem hiding this comment.
Avoid more than 3 levels of block nesting.
Convert if nested inside else to elsif.
There was a problem hiding this comment.
I would use unless @work.errors.empty? and avoid nesting.
| @@ -306,7 +306,7 @@ def create | |||
| render :new && return | |||
| elsif params[:cancel_button] | |||
| flash[:notice] = ts('New work posting canceled.') | |||
| redirect_to current_user && return | |||
| redirect_to current_user and return | |||
There was a problem hiding this comment.
No. This had actually broken that code path so my change fixes this.
There was a problem hiding this comment.
No change needed, just noting that we use redirect_to(current_user) && return in some places to get around this warning.
ariana-paris
force-pushed
the
AO3-4808-fandom-500-edit-tags
branch
from
205da81
to
5e13eee
Compare
ariana-paris
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
ariana-paris
force-pushed
the
AO3-4808-fandom-500-edit-tags
branch
from
5e13eee
to
715fbf9
Compare
| @work.minor_version = @work.minor_version + 1 | ||
| @work.save | ||
| flash[:notice] = ts('Work was successfully updated.') | ||
| redirect_to(@work) and return |
|
Looks good to me. |
Issue
https://otwarchive.atlassian.net/browse/AO3-4808
Purpose
Fixes the Broken on Test issue where no message appears when using Edit Tags to remove the fandom.
Testing
See Jira.