AO3-5050 Modified collections page subtitle to match other controllers. #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 8, 2017
| @@ -30,7 +30,7 @@ def index | |||
| @collections = @collection.children.by_title.includes(:parent, :moderators, :children, :collection_preference, owners: [:user]).paginate(page: params[:page]) | |||
| elsif params[:user_id] && (@user = User.find_by(login: params[:user_id])) | |||
| @collections = @user.maintained_collections.by_title.includes(:parent, :moderators, :children, :collection_preference, owners: [:user]).paginate(page: params[:page]) | |||
| @page_subtitle = ts("created by ") + @user.login | |||
| @page_subtitle = ts("%{username} - Collections", username: @user.login) | |||
There was a problem hiding this comment.
Prefer annotated tokens (like %s) over template tokens (like %{foo}).
|
Sorry, please ignore accidental close. |
elzj
pushed a commit
that referenced
this pull request
Sep 22, 2017
…#3073) * Revert "Update nokogiri (#3071)" This reverts commit 27c45c9. * Revert "A03-5042 Add only_path:false to byline calls in download partials (#3070)" This reverts commit f6fff7d. * Revert "AO3-5176: Add more indexes to tag nominations (#3066)" This reverts commit 912e6bc. * Revert "AO3-4952 REDIS AUTOCOMPLETE missing lib files (#3068)" This reverts commit 1733fb5. * Revert "AO3-4748 Give the date on unposted prompt meme claims the proper margin to avoid the icon (#2649)" This reverts commit aae900b. * Revert "AO3-5178: Fix slow tag set callback (#3067)" This reverts commit 80515a9. * Revert "AO3-4533 Make AO3 logo alt text shorter (too long for screen readers) (#2642)" This reverts commit 923f342. * Revert "AO3-4729 Accept 5 abuse reports per profile per month (#2906)" This reverts commit 73c2bc6. * Revert "AO3-4952 Move autocomplete to its own Redis instance (#2889)" This reverts commit c27d54c. * Revert "AO3-5011 Reorder FAQ intro information (#2909)" This reverts commit 827b37d. * Revert "AO3-5091: Fix 500 error on claims page caused by deleted users (#2982)" This reverts commit fe2cf53. * Revert "AO3-5050 Modified collections page subtitle to match other controllers. (#2991)" This reverts commit a9c2fe8. * Revert "AO3-2556 Cascade comment destruction to parent placeholders. (#2859)" This reverts commit 27e18a5. * Revert "AO3-5042 Use _url for absolute links in bylines and download afterword (#3052)" This reverts commit 4837394. * Revert "AO3-5065 Fix error where posting chapter would not post work (#2961)" This reverts commit e66234a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5050
Purpose
Adjusts the collections page subtitle to match other pages like bookmarks, works, etc ([username] - Collections).
Testing
I don't think this is necessary, it's a simple string change. No functionality was added or removed.
References
No
Credit
What name do you want us to use to credit your work in the Archive of Our Own's Release Notes?
MaxwellsDaemon
What pronouns do you prefer (she/her, he/him, zie/hir etc)?
Him