AO3-5192: Add sites to https list, rescue to after task #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 4, 2017
| @@ -568,9 +568,16 @@ namespace :After do | |||
| desc "Enforce HTTPS where available for embedded media" | |||
| task(enforce_https: :environment) do | |||
| Chapter.find_each do |chapter| | |||
| if chapter.id % 1000 == 0 | |||
There was a problem hiding this comment.
Use (chapter.id % 1000).zero? instead of chapter.id % 1000 == 0.
elzj
added
Awaiting Review
Priority: High - Broken on Test
zz9pzza
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5192
Purpose
Expand https list
Testing
See issue