AO3-5204 Upgrade scrollTo plugin to fix problem in Chrome #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 19, 2017
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * Copyright (c) 2007-2012 Ariel Flesler - aflesler(at)gmail(dot)com | http://flesler.blogspot.com | |||
| * Dual licensed under MIT and GPL. | |||
| * Copyright (c) 2007 Ariel Flesler - aflesler ○ gmail • com | https://github.com/flesler | |||
| define(['jquery'], factory); | ||
| } else if (typeof module !== 'undefined' && module.exports) { | ||
| // CommonJS | ||
| module.exports = factory(require('jquery')); |
| 'use strict'; | ||
| if (typeof define === 'function' && define.amd) { | ||
| // AMD | ||
| define(['jquery'], factory); |
| $(window).scrollTo( target, duration, settings ); | ||
| ;(function(factory) { | ||
| 'use strict'; | ||
| if (typeof define === 'function' && define.amd) { |
| function both( val ){ | ||
| return typeof val == 'object' ? val : { top:val, left:val }; | ||
| function both(val) { | ||
| return $.isFunction(val) || $.isPlainObject(val) ? val : { top:val, left:val }; |
| case 'object': | ||
| if (targ.length === 0) return; |
There was a problem hiding this comment.
Expected '{' and instead saw 'return'.
| // Null target yields nothing, just like jQuery does | ||
| if (target == null) return; | ||
| if (target === null) return; |
There was a problem hiding this comment.
Expected '{' and instead saw 'return'.
| }; | ||
| function isWin(elem) { | ||
| return !elem.nodeName || | ||
| $.inArray(elem.nodeName.toLowerCase(), ['iframe','#document','html','body']) !== -1; |
| * Copyright (c) 2007 Ariel Flesler - aflesler ○ gmail • com | https://github.com/flesler | ||
| * Licensed under MIT | ||
| * https://github.com/flesler/jquery.scrollTo | ||
| * @projectDescription Lightweight, cross-browser and highly customizable animated scrolling with jQuery |
| * @projectDescription Easy element scrolling using jQuery. | ||
| * http://flesler.blogspot.com/2007/10/jqueryscrollto.html | ||
| * jQuery.scrollTo | ||
| * Copyright (c) 2007 Ariel Flesler - aflesler ○ gmail • com | https://github.com/flesler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5204
Purpose
Upgrades the scrollTo plugin so scrolling to comments works in Chrome.
Testing
Refer to JIRA.