Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5607 Move Travis to Ubuntu Xenial 16.04 #3514

Merged
merged 1 commit into from Feb 9, 2019

Conversation

redsummernight
Copy link
Member

Issue

https://otwarchive.atlassian.net/browse/AO3-5607

Purpose

https://docs.travis-ci.com/user/reference/xenial/

Travis offers MySQL 5.7 by default with this OS, so no need to bring in mysql-5.7-trusty or run mysql_upgrade.

Use the correct wkhtmltox package.

Cleanup:

  • No need to specify the Ruby version in .travis.yml, since Travis can detect it from .ruby-version.
  • Remove IRC notifications.
  • Rearrange the build phases in the order they're run.

Testing Instructions

None, automated.

Travis offers MySQL 5.7 by default with this OS, so no need to
bring in mysql-5.7-trusty or run mysql_upgrade.

Use the correct wkhtmltox package.

Cleanup:

- No need to specify the Ruby version in .travis.yml, since Travis
  can detect it from .ruby-version.
- Remove IRC notifications.
- Rearrange the build phases in the order they're run.
@redsummernight redsummernight added Priority: Low Awaiting Review Scope: Tests Only Only changes automated tests or test configuration labels Feb 3, 2019
@sarken
Copy link
Member

sarken commented Feb 5, 2019

Just checking -- will this be using the right version of Ruby? The docs say the default is 2.5.3p105.

@sarken
Copy link
Member

sarken commented Feb 5, 2019

JFC, reading comprehension fail. Never mind my above comment!

@sarken sarken requested a review from zz9pzza February 5, 2019 01:40
@zz9pzza zz9pzza merged commit 139f476 into otwcode:master Feb 9, 2019
@redsummernight redsummernight deleted the AO3-5607-xenial branch February 9, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Reviewed: Ready to Merge Scope: Tests Only Only changes automated tests or test configuration
Projects
None yet
3 participants