AO3-5693 Support HTML5 media tags #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 14, 2019
houndci-bot
reviewed
Sep 14, 2019
redsummernight
added
the
Has Production Config Changes
houndci-bot
reviewed
Sep 20, 2019
| def sanitized_classes | ||
| user_classes.split(" "). | ||
| select { |user_class| valid_class?(user_class) }. | ||
| join(" ") |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
| # then rejoin them | ||
| def sanitized_classes | ||
| user_classes.split(" "). | ||
| select { |user_class| valid_class?(user_class) }. |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Use 2 (not 13) spaces for indenting an expression spanning multiple lines.
houndci-bot
reviewed
Sep 20, 2019
houndci-bot
reviewed
Sep 20, 2019
sarken
reviewed
Sep 20, 2019
|
Just noting that I don't have any additional comments on |
sarken
changed the title
|
Just switching labels since this has been reviewed and needs a few tweaks. |
There was a problem hiding this comment.
There are comments remaining:
- Hound's Performance/Casecmp recommendations: AO3-5693 Support HTML5 media tags #3637 (comment) and AO3-5693 Support HTML5 media tags #3637 (comment).
- AO3-5693 Support HTML5 media tags #3637 (comment)
Otherwise looks good to me. I've collapsed the rest.
redsummernight
approved these changes
Oct 13, 2019
redsummernight
added
Reviewed: Ready to Merge
and removed
Reviewed: Action Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5693
Purpose
Adds support for audio and video tags in the same fields that allow video embeds and sets up a blacklist option in the config. Also extracts the existing sanitize transformers out into separate files for improved comprehensibility.
Testing Instructions
See issue for which attributes are allowed and which should be stripped out by the sanitizer.