Fix issue 2790 with alphabetical pagination for people index #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzj
added a commit
that referenced
this pull request
Jan 23, 2012
Fix issue 2790 with alphabetical pagination for people index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 2790 with a missing closing div and missing classes on people pages' alphabetical pagination: http://code.google.com/p/otwarchive/issues/detail?id=2790
This kind of snowballed. The title-instead-of-class issue in people/index also appeared in people/show, and once the classes were added, the CSS and the alphabet helper both needed to be tweaked so the newly-styled alphabetical pagination displayed properly.