AO3-4820 AO3-3810 Validate skins with "archive" in title #4771
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
It should depend on the type of skin -- superadmins can edit site or work skins, and support admins can edit work skins only. otwarchive/app/policies/skin_policy.rb Lines 3 to 4 in acebcad |
There was a problem hiding this comment.
I pointed out a few code style things that would be nice to change.
It looks like reviewdog got a bit confused with the lines in this file for some reason (pointing out issues for code that didn't change), which might get fixed if you merge master into this branch. But the Style/ParenthesesAroundCondition violation that hound points out should indeed be fixed.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
the
Has Migrations
|
I added a migration to make the skin title index unique as Rubocop suggested, as it seems that would be beneficial for efficiency. |
|
Just dropping a note here that I have run out of knowledge to continue reviewing this PR in particular, someone else will have to review the functional code. But the locale looks good :) |
| title: | ||
| taken: must be unique | ||
| invalid_media: We don't currently support the media type %{media}, sorry! If we should, please let Support know. | ||
| no_public_preview: You need to upload a screencap if you want to share your skin. |
There was a problem hiding this comment.
Noting that we would update the wording here, but at some point this feature is going away anyways so it's not really worth updating only to delete later
brianjaustin
added
Reviewed: Action Needed
and removed
Coder Has Actioned Review
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
weeklies
force-pushed
the
AO3-4820-AO3-3810
branch
3 times, most recently
from
96805e8
to
af02489
Compare
weeklies
force-pushed
the
AO3-4820-AO3-3810
branch
from
af02489
to
8d6a175
Compare
weeklies
force-pushed
the
AO3-4820-AO3-3810
branch
from
5650a47
to
397fa8a
Compare
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Issue
https://otwarchive.atlassian.net/browse/AO3-4820
https://otwarchive.atlassian.net/browse/AO3-3810
Purpose
Note: I am not sure which admins should be allowed to edit a skin with “Archive”.Testing Instructions
See both issues.