AO3-5351 Make remaining text in feedback response i18n-able #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if you added |
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
|
@Bilka2 indeed, thanks! I've added those |
Bilka2
approved these changes
Apr 11, 2024
brianjaustin
added
Reviewed: Ready to Merge
Scope: i18n Only
sarken
reviewed
May 15, 2024
There was a problem hiding this comment.
While we're here, can we rename feedback_response to just plain feedback in the mailer preview? Translation said it's a bit less confusing if the preview name matches the key for the mailer when possible.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Bilka2
approved these changes
May 16, 2024
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
sarken
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5351
Purpose
I18n-ising the remaining text in the feedback (support ticket) response emails. I didn't add a preview since I did that already in #4772.
Credit
Brian Austin (they/he)