Fix for issue 3074 #641
Merged
Fix for issue 3074 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <dt><%= stat.to_s.titleize %></dt> | ||
| <dd><%= @totals[stat] %></dd> | ||
| <% end %> | ||
| <% unless @user.preference.hide_hit_counts %> | ||
| <dt><%= "Hits" %></dt> |
There was a problem hiding this comment.
Tiny, tiny thing: as we're moving closer to having translations, would you have time to edit this string to be surrounded by the translation function? That's the ts() that you might have noticed around other strings. g <3!
| @@ -27,4 +27,7 @@ def fix_time_zone | |||
| self.time_zone = try if ActiveSupport::TimeZone[try] | |||
| end | |||
|
|
|||
| def hide_hit_counts | |||
There was a problem hiding this comment.
Only bit of advice here would be that in Ruby, it's pretty standard for methods that return true or false to end in a question mark, like: def hide_hit_counts? That just makes it a little clearer to someone who's looking at the code that we're checking a value rather than performing an action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.