Check for errors when setting the last modified time #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospb19
force-pushed
the
refactor-last-modified-times-when-unpacking-archives
branch
2 times, most recently
from
24e419b
to
08ec218
Compare
Last modified time is a piece of metadata that is available when decompressing an archive
marcospb19
force-pushed
the
refactor-last-modified-times-when-unpacking-archives
branch
from
08ec218
to
acb7566
Compare
figsoda
deleted the
refactor-last-modified-times-when-unpacking-archives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #274 reopened.
This PR refactors the way we set the 'last modified time'
when unpacking a Zip archive.
Replacing the usage of
libcandunsafeby thefiletimecrate.