Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS-288: ROS2 crashes when standby mode is set and then set to normal [HUMBLE] #293

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Feb 9, 2024

Related Issues & PRs

Summary of Changes

  • Use timeout when waiting for packets to be proceed in case no packets are coming

Validation

  • driver functionality sustained
  • launch a ros2 node then perform a set_config call with STANDBY mode, see the driver idles
  • perform a follow set_config call this time with NORMAL mode and verify that driver resumes

@Samahu Samahu added the enhancement New feature or request label Feb 9, 2024
@Samahu Samahu self-assigned this Feb 9, 2024
@Samahu Samahu changed the title ROS-288: ros2 crashes when standby mode is set and then set to normal humble ROS-288: ros2 crashes when standby mode is set and then set to normal [HUMBLE] Feb 9, 2024
@Samahu Samahu changed the title ROS-288: ros2 crashes when standby mode is set and then set to normal [HUMBLE] ROS-288: ROS2 crashes when standby mode is set and then set to normal [HUMBLE] Feb 9, 2024
Copy link

@mtswisher mtswisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the problem for me on Humble!!

@Samahu Samahu merged commit 11287a9 into ros2 Feb 9, 2024
3 checks passed
@Samahu Samahu deleted the ROS-288_ROS2_crashes_when_standby_mode_is_set_and_then_set_to_normal_HUMBLE branch February 9, 2024 17:41
AchmadFathoni pushed a commit to AchmadFathoni/ouster-ros that referenced this pull request Feb 16, 2024
EirikKolas added a commit to vortexntnu/ouster-lidar-ros2-driver that referenced this pull request Mar 23, 2024
* SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (ouster-lidar#244)

* rename package ouster_msgs to avoid conflict name conflict in ros index
* set ouster_sensor_msgs version number to match with ouster_ros package

* SW-5466: Support Velodyne and other point types in ouster-ros driver (ouster-lidar#216)

* Quick protoype of Velodyne point type
* Add PointXYZIR point type + other major pcl point types
* Include point meta functions and point transform by the ouster_ros namesapce
* Wrap point meta functions with a namespace and use shorter names for the functions +
* Add a seed test module for the point_cloud_compose methods +
 Add description for the point_cloud_compose methods + refactor code and add compile time checks.
* Propagate error state, warn about potential incompatible profile, propagate error state
* Add minimal documentation about the new `point_type` parameter.

* SW-5466: Support Velodyne point type in the ROS driver amendments (ouster-lidar#254)

* Add support to control point_type through launch.xml files +
* Add a note to CHANGELOG about the breaking change for ptp/utc time offset

* SW-5623: Bump up ouster_client to 20231031 release (ouster-lidar#262)

* Bump ouster-client to 2023103 release
* fix: gracefully stop the driver when shutdown is requested.

* ROS-196: laser scan from ros driver is not properly aligned with point cloud [humble] (ouster-lidar#203)

* Apply destagger to laser scan + Add laser to RVIZ
* Align LaserScan with the PointCloud
* Apply proper pixel shift
* Resolve the issue of zeroed laserscan on dual mode
* Address an issue where LaserScan appeared different on FW prior to 2.4
* Fix the issue for odd numbers
* List selected sensors on the main page + Update RVIZ config to highlight the 2D LaserScan.

* Use timeout when waiting for packets to be proceed in case they don't come (ouster-lidar#293)

* docs: fix spelling mistakes (ouster-lidar#296)

---------

Co-authored-by: Ussama Naal <606033+Samahu@users.noreply.github.com>
Co-authored-by: Andre Nguyen <andre-nguyen@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants