-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lock free ring buffer with throttling [HUMBLE/IRON] #321
Implement lock free ring buffer with throttling [HUMBLE/IRON] #321
Conversation
(cherry picked from commit ade5822)
We tested both, this branch and this attempt #302 to solve the problem with missing parts of the point cloud. We set the recv buffer size to the following values sudo sysctl -w net.core.rmem_default=26214400
sudo sysctl -w net.core.rmem_max=26214400 on the host machine and also set For all resolutions, the point cloud looks fine if only RVIZ is used for visualization (single subscriber). |
We also tested this PR with an We tested both 1024x10 and 1024x20 modes and the issue was not present in any of those. |
@TillBeemelmanns @marioney thank you both for the feedback. @TillBeemelmanns sorry that didn't help with your situation .. I still have one TODO item that I predict it to help with the delay and might improve things overall. I should have this PR completed and merged by next week. |
Tested on Great work! |
Thanks @mkiael for the feedback. I will proceed with the PR as is since it resolves the issue for most of the driver users and will address the rest of suggested improvements in a separate PR. |
Related Issues & PRs
Problem Analysis
Summary of Changes
TODO(s):
os_sensor_nodelet
.Validation
/ouster/points