Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS Service to configure the Lidar #194

Closed
ckurtz22 opened this issue Dec 8, 2020 · 9 comments
Closed

ROS Service to configure the Lidar #194

ckurtz22 opened this issue Dec 8, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request ROS Sample ROS driver

Comments

@ckurtz22
Copy link

ckurtz22 commented Dec 8, 2020

Would be really great if we had a ROS service that allowed us to configure the Lidar, or at the very least do stuff such as put the Lidar in/out of standby mode.

@dmitrig dmitrig added the enhancement New feature or request label Dec 8, 2020
@msadowski
Copy link

I'm also very interested about being able to put the lidar in 'standby' or 'pause' modes so that no lidar information is published. Is anything like that available already?

@dmitrig
Copy link
Contributor

dmitrig commented Dec 9, 2020

to clarify - you'd also want configuration (including standby mode) available specifically as a ROS service?

@ckurtz22
Copy link
Author

ckurtz22 commented Dec 9, 2020

I'm also very interested about being able to put the lidar in 'standby' or 'pause' modes so that no lidar information is published. Is anything like that available already?

Yeah the newest 2.0 firmware added a configuration that allows you to put the lidar in standby where it stops the motor and laser and only draws 5W of power. I'm not sure whether it stops sending packets, haven't checked.

@kairenw
Copy link
Contributor

kairenw commented Apr 27, 2021

Hi @ckurtz22,

The newest master has an early version of an API covering the full sensor configuration. It may change, and it isn't available as a ROS service, but thought it might interest you. Let us know if the functionality is useful!

@ckurtz22
Copy link
Author

Hi @ckurtz22,

The newest master has an early version of an API covering the full sensor configuration. It may change, and it isn't available as a ROS service, but thought it might interest you. Let us know if the functionality is useful!

Oh, that's sweet! Thanks for letting me know. I may make a PR adding a ROS service at some point but haven't had much time to work on my project using this lately.

@RFRIEDM-Trimble
Copy link
Contributor

RFRIEDM-Trimble commented Jun 8, 2021

I'm also very interested about being able to put the lidar in 'standby' or 'pause' modes so that no lidar information is published. Is anything like that available already?

I was also looking into this. In ROS2, there explicit steps for set up and tear down of the connection, in which TCP commands could be issued to turn the sensor in NORMAL when the driver node starts running and STANDBY when the driver stops. I don't see any reason the sensor should be spinning if there isn't something listening.

I am also interested in adding the configuration as a ROS2 service. It does already support GetMetadata, but no setting of parameters from a ROS2 service already running. @ckurtz22 Are you interested in ROS1 or ROS2?

@jeremyroy
Copy link

I am also interested in this feature, for ROS1

@skarful
Copy link

skarful commented Dec 15, 2021

Hi everyone, I was looking at something similar for my application. I used the API mentioned by @kairenw and created a ROS service for sending config params to the lidar. I've sent in a pull request (#331). Until it gets reviewed, you can use the ros_config_service branch forked on my github to accomplish this (https://github.com/skarful/ouster_example/tree/ros_config_service). I've tested this with the OS1 and the OS2 lidars. Hope it helps :)

@Samahu Samahu added the ROS Sample ROS driver label May 16, 2022
@Samahu Samahu self-assigned this Aug 25, 2022
@Samahu
Copy link
Collaborator

Samahu commented Aug 25, 2022

@ckurtz22 and everyone else who might interested, the feature requested has been implemented and is part of the last release. As I responded to @skarful on the PR #331, the functionality is the same with few differences.

The new service which is named /ouster/set_config takes a path to a configuration file rather than a string, another thing worth noting is that while the service operational it is still experimental since there are certain scenarios that does not supported.

Please refer to the PR #420 for additional details.

Since the requested feature is now part of the SDK i will close this issue.

@Samahu Samahu closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ROS Sample ROS driver
Projects
None yet
Development

No branches or pull requests

8 participants