Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for FW 2.4. See changelog for details #420

Merged
merged 1 commit into from Aug 23, 2022
Merged

Conversation

kairenw
Copy link
Contributor

@kairenw kairenw commented Aug 23, 2022

  • Drop support for Ubuntu 16.04, ROS kinetic
  • Drop support for sensors on FW < 2.0
  • Require C++ 14 for build
  • Use sensor http interface for sensors on FW 2.1+
  • Switch from nodes to nodelets in ouster_ros
  • Separate ROS launch files for play, replay, and record
  • Add new experimental ROS config services set_config and get_config
  • Bugfixes. See Changelog

* Drop support for Ubuntu 16.04, ROS kinetic
* Drop support for sensors on FW < 2.0
* Require C++ 14 for build
* Use sensor http interface for sensors on FW 2.1+
* Switch from nodes to nodelets in ouster_ros
* Separate ROS launch files for play, replay, and record
* Add new experimental ROS config services set_config and get_config
* Bugfixes. See Changelog
@kairenw kairenw self-assigned this Aug 23, 2022
@kairenw kairenw merged commit fa045e5 into master Aug 23, 2022
@kairenw kairenw deleted the fw24-release branch August 23, 2022 23:38
@Samahu
Copy link
Collaborator

Samahu commented Aug 23, 2022

@kairenw we forgot to advertise the new timestamp_mode TIME_FROM_ROS_TIME option and include it into the release note

@kairenw
Copy link
Contributor Author

kairenw commented Aug 24, 2022

whoops! good catch

@peci1
Copy link

peci1 commented Aug 25, 2022

This doesn't make any sense:

catkin_package(
LIBRARIES nodelet_os_cloud
CATKIN_DEPENDS nodelet roscpp std_msgs
)
catkin_package(
LIBRARIES nodelet_os_image
CATKIN_DEPENDS nodelet roscpp std_msgs
)

There are no targets called nodelet_os_cloud and nodelet_os_image. I guess this will completely break any library depending on ouster_ros because it would be searching for these nonexisting .so files. Also, you call catkin_package three times in the CMakeLists.txt. That is also highly unusual (I even wonder it works).

@peci1
Copy link

peci1 commented Aug 25, 2022

In ouster_ros, you also have to install the nodelets_os.xml file to the package share destination.

@Samahu
Copy link
Collaborator

Samahu commented Aug 25, 2022

@peci1 You are absolutely right, we should have revised these statements when we switched from nodes to notelets.

@Samahu
Copy link
Collaborator

Samahu commented Aug 31, 2022

@peci1 the issues you reported about the FW 2.4 release have been addressed as part of #425 pull request. Always let us know of any problems that you may find.

@Samahu Samahu self-assigned this Sep 2, 2022
@Samahu Samahu added the enhancement New feature or request label Sep 2, 2022
@Samahu Samahu added the ROS Sample ROS driver label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ROS Sample ROS driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants