Amend/update frontend dependencies #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end-dependencies # Conflicts: # frontend/angular-cli.json # frontend/package.json # frontend/src/app/app.module.ts # frontend/src/app/shared/notifications/notification-wrapper.service.ts # frontend/src/app/shared/services/factories.ts # frontend/yarn.lock
jmesserli
reviewed
Feb 10, 2017
| { | ||
| "root": "src", | ||
| "outDir": "dist", | ||
| "assets": [ |
There was a problem hiding this comment.
do we actually use jquery or materialize?
There was a problem hiding this comment.
I'm not really sure. I need some time to check that but I don't have it.
|
can you please re-enable the ngBuild task in gradle? |
|
Why re-enable? It would fail tough expect we'd move to npm. |
|
I thought you fixed it, that's why
Mario Kunz <notifications@github.com> schrieb am Fr., 10. Feb. 2017, 22:33:
… Why re-enable? It would fail tough expect we'd move to npm.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAlbEgQgxyI0T2yFWDzOdKyRzo8AYk9-ks5rbNepgaJpZM4L9y04>
.
|
|
What did I fix? |
|
Okay it's fine then, you can merge it
Mario Kunz <notifications@github.com> schrieb am Fr., 10. Feb. 2017, 22:38:
… What did I fix?
The factory: yes
But there is another error which is caused by yarn but don't ask me why
this happens.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAlbEkPUGx9mjXZIESb9No0p10spwfhHks5rbNjdgaJpZM4L9y04>
.
|
|
I hope that this error will be fixed in a future release of yarn or @angular/cli |
|
We can hope ¯_(ツ)_/¯ |
|
And I'm pretty sure that sentence does not exist in english |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes nothing
Summary of changes:
important
currently the build is only working correctly when the dependecies were installed with npm but not yarn
see this issue
so you have to run yarn first and before you run
ng serveorng buildyou need to runnpm iI made sure to:
CTRL + ALT + L)Please review @jmesserli @needToRoll / cc: @outcobra/developers.