ERROR in AppModule is not an NgModule

[tHesTx]

Please provide us with the following information:

OS?

Windows 7

Versions.

ng --version
@angular/cli: 1.0.0-beta.31
node: 7.2.0
os: win32 x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.7
@ngtools/webpack: 1.2.9

$ npm list -g --depth=0
C:\Users\Macpro\AppData\Roaming\npm
+-- @angular/cli@1.0.0-beta.31
+-- cordova@6.5.0
+-- grunt-cli@1.2.0
+-- http-server@0.9.0
+-- ionic@2.2.1
+-- minimatch@3.0.3
+-- node-uuid@1.4.7
+-- npm@4.2.0
`-- typescript@2.1.6

Repro steps.

I've tried to update the angular-cli with these steps: https://github.com/angular/angular-cli#updating-angular-cli

I've done global update and local project as well, all good until I try to serve the app - it gives me the below error

The log given by the failure.

$ ng serve

ERROR in AppModule is not an NgModule
ERROR in ./src/main.ts
Module build failed: TypeError: Cannot read property 'newLine' of undefined
at Object.getNewLineCharacter (C:\Users\Macpro\Desktop\Test\Angular2\Angular2\CLI\puzzleTest\node_modules\typescript\lib\typescript.js:8062:20)
at Object.createCompilerHost (C:\Users\Macpro\Desktop\Test\Angular2\Angular2\CLI\puzzleTest\node_modules\typescript\lib\typescript.js:44978:26)
at Object.ngcLoader (C:\Users\Macpro\Desktop\Test\Angular2\Angular2\CLI\puzzleTest\node_modules@ngtools\webpack\src\loader.js:341:33)
@ multi webpack-dev-server/client?http://localhost:4200/ ./src/main.ts
webpack: Failed to compile.

---

I also got this "minimatch" errror every time I try to update or install somtehing:
npm update -g

npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

But as you can see above I have "minimatch@3.0.3" - anyway this is not the problem here

Mention any other details that might be useful.

I've tried to update the typescript like I've seen on the web but with no success. I also

---

Thank you for your time!

[SanderElias]

I got the same problem. On ubuntu 16. But only on the first build:

The only change I made was adding an empty line to the app.module.ts

[dessalines]

Don't ask me why, but I think this is a yarn issue. Running

rm -rf node_modules
npm i
ng serve

fixes the problem, but the problem remains if you do yarn instead of npm i.

EDIT: another thing that worked was reinstalling yarn : https://yarnpkg.com/lang/en/docs/install/#linux-tab

[pinalbhatt]

Thanks @dessalines
Not sure whats issue with yarn but your instructions worked.

[SanderElias]

Ok, I reinstalled yarn using my package manager, removed the node_moduls. used yarn to install.
Problem stays the same.
removed node_modules yet again, and used npm to install, the problem goes away. Even if you use yarn after that.

conclusion. This problem happens and is reproducible if you use yarn to install your packages. (which is a shame, as yarn is at least 2 times faster in my situation.)

reason (an educated guess!): As yarn is more strict on installing, it probably forces a slightly older dependency in the tree somewhere.

[djedje72]

This problem seems to occur with Typescript 2.1.6.

If you clean your node modules, change Typescript to typescript@2.1.5 and do a yarn install or npm install, the problem should be resolved.

[tHesTx]

So, for me, should I install this yarn? I do not use it

[SanderElias]

@tHesTx, no, just use npm install instead. For me, the problem occurs when I use yarn instead. It is solved if I use npm. Also, in my case it was just on the first run, after that it worked ok.

[djedje72]

@SanderElias Yes it was just on the first run for ng serve but can you do ng build?
@tHesTx i think you can do npm install if you don't use yarn

[tHesTx]

I don't know what to do anymore, nothing works. DO I have to update something in package.json or angular-cli.json in my project ? Building gives the same error

[djedje72]

@tHesTx For me, i'd to change
"typescript": "2.1.6"
to
"typescript":"2.1.5"
in my package.json file because i use local typescript version.

If you use global version, you can try:
npm uninstall -g typescript
then
npm install -g typescript@2.1.5

[tHesTx]

@djedje72 I've done that, currently is set to "typescript": "2.1.5". Before to do the first angular-cli update which got me to this point it was like this: "typescript": "~2.0.3". Uninstall and reinstall too. I've also updated the "@angular/cli": "1.0.0-beta.24", "angular-cli": "1.0.0-beta.24", from "devDependencies" to 31, in angular-cli.json: "version": "1.0.0-beta.24", -> to 31 as well.
PS: If I do these changes before npm install, when I run npm install gives me some errors about the CLI version, somthing like the requested(beta.31) version not exists

[tHesTx]

Ok, I've generated a new app with angular-cli which works, but in package.json it uses this: "typescript": "~2.0.0" - but I have installed 2.1.5 globally. Why is that?

[aviramga]

Your local Typescript version doesn't necessarily have to match your global. CLI generates a package.json with default dependencies it requires, but you can (and should) updated them according to your needs.

I actually had an issue trying to run angular-2.4.7 with typescript 2.0.0 but after updating my project's package.json with typescript 2.1.6 the issue was resolved.
I assume if you do the same it will resolve your issue as well.

#goodnessSquad