Comment link lost

[MorganReid]

It doesn't happen necessarily, but it happens often.

To Reproduce
Steps to reproduce the behavior:

1. Open a specific wiki(not in edit mode) by account A
2. select specific content(such as Note) and comment
3. Open same wiki by account B
4. specific content(such as Note) not a comment but a common text

Expected behavior
specific content(such as Note) is a comment by account B.

Screenshots
account A:

account B:

Outline (please complete the following information):

• Install: self hosted
• Version: v0.71.0

Desktop (please complete the following information):

• OS: ubuntu
• Browser: chrome
• Version: 109.0.5414.119 (Official Build) (64-bit)

Through the console, I found that the comment-marker will be added to the commented content. This does not exist when it is not a comment.

I queried the database and found the documents and comments tables, but it seems that the mapping relationship between comments and corresponding content is not recorded in it. How is the comment function implemented?

[tommoor]

I cannot reproduce with your steps, so as you say there must be more to it. The marker in the content is stored as part of the document.state – it's not human readable as it's a CRDT stored in binary format.

Your symptoms would suggest that the edit to the state was not persisted for some reason, if you can reproduce and get server logs that might help.

[verement]

It seems that if the commenting user has only View permissions, then the marker for the resulting comment will not be visible to anyone except that user.

[tommoor]

This sounds like it could be the issue, the comment on a text functionality should be unavailable to viewers.

[NangeGao]

This sounds like it could be the issue, the comment on a text functionality should be unavailable to viewers.

I think viewers also need to have comment functions. For example, when we publish an instruction manual to users, they need a channel for feedback.

[tommoor]

Viewers can still comment on the document from the sidebar, but it's a limitation that they cannot comment on text for now as it actually modifies the document.

[verement]

Viewers can still comment on the document from the sidebar, but it's a limitation that they cannot comment on text for now as it actually modifies the document.

Would there be any reason not to allow this?

[tommoor]

Not from a product point of view, it's mainly a technical limitation. To keep the focus on this issue, if there is a way to create a text selection comment as a viewer then that would be the bug here for now.