Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid diagrams are not visible in PDF or HTML download. & +1 blank page in PDF download #6205

Closed
fwaegele opened this issue Nov 23, 2023 · 2 comments
Assignees
Labels

Comments

@fwaegele
Copy link

Either on the website or in the macOS app:
When downloading a page with a mermaid diagram as PDF or HTML, the diagram is not showing.

In the PDF download there is also one blank page added. This also happens if there is no diagram.

When using the system print dialog the diagram is printed.

  • Outline hosted trial version at getoutline.com
  • Used web browser Edge: Version 119.0.2151.72 (Official build) (arm64)
  • Also Safari: Version 17.0 (19616.1.27.211.1)
  • MacOs app version: Version 1.2.2
@fwaegele fwaegele added the bug label Nov 23, 2023
@tommoor tommoor self-assigned this Nov 23, 2023
@tommoor
Copy link
Member

tommoor commented Nov 23, 2023

Thanks for raising, I have a solution for this and should get a fix out within the day

@fwaegele
Copy link
Author

@tommoor Thanks a lot! It works :) 👍

truecharts-admin added a commit to truecharts/charts that referenced this issue Dec 6, 2023
…30dfb (#15817)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [outlinewiki/outline](https://togithub.com/outline/outline) | minor |
`0.73.1` -> `0.74.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>outline/outline (outlinewiki/outline)</summary>

###
[`v0.74.0`](https://togithub.com/outline/outline/releases/tag/v0.74.0)

[Compare
Source](https://togithub.com/outline/outline/compare/v0.73.1...v0.74.0)

**Note:** Minimum Node version changed to 18 – if using Docker
installation this is handled for you.

##### Improvements

- Clicking on a link while editing will now automatically select the
entire link
- Mermaid diagrams are now rendered in HTML exports in
[outline/outline#6205
-   Added "Share" option to document menu on mobile
-   New translations
-   Updated to Node 20 LTS
- \[API] `comments.list` endpoint can now be used without a document ID

##### Fixes

-   Find and replace dialog no longer gets stuck without replace button
- Fixed corruption in imports in
[outline/outline#6162
-   Fixed recurring crash when DataDog and Sentry are enabled.
-   Fixed display of video nodes in document history
-   Fixed members can now create templates again
- Fixed viewing public shares failed if user has an expired token in
[outline/outline#6134
- Restored ability to comment in code blocks in
[outline/outline#6154
- Comment functionality should not show in toolbar for view-only users
in
[outline/outline#6011
- Added support for tldraw snapshot links in
[outline/outline#6210
-   Restored PWA install in recent Chrome versions
- Fixed extra empty page in HTML exports in
[outline/outline#6205
- Emoji in template titles are now applied correctly in
[outline/outline#6169
-   Many dependency updates

#### New Contributors

- [@&#8203;NextFire](https://togithub.com/NextFire) made their first
contribution in
[outline/outline#6134
- [@&#8203;EspadaV8](https://togithub.com/EspadaV8) made their first
contribution in
[outline/outline#6217
- [@&#8203;RayYH](https://togithub.com/RayYH) made their first
contribution in
[outline/outline#6238

**Full Changelog**:
outline/outline@v0.73.1...v0.74.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44OC4yIiwidXBkYXRlZEluVmVyIjoiMzcuODguMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
calvinbui pushed a commit to calvinbui/ansible-monorepo that referenced this issue Dec 7, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [outlinewiki/outline](https://github.com/outline/outline) | minor | `0.73.1` -> `0.74.0` |

---

### Release Notes

<details>
<summary>outline/outline (outlinewiki/outline)</summary>

### [`v0.74.0`](https://github.com/outline/outline/releases/tag/v0.74.0)

[Compare Source](outline/outline@v0.73.1...v0.74.0)

**Note:** Minimum Node version changed to 18 – if using Docker installation this is handled for you.

##### Improvements

-   Clicking on a link while editing will now automatically select the entire link
-   Mermaid diagrams are now rendered in HTML exports in outline/outline#6205
-   Added "Share" option to document menu on mobile
-   New translations
-   Updated to Node 20 LTS
-   \[API] `comments.list` endpoint can now be used without a document ID

##### Fixes

-   Find and replace dialog no longer gets stuck without replace button
-   Fixed corruption in imports in outline/outline#6162
-   Fixed recurring [OOM crash](https://twitter.com/tommoor/status/1730985110806184265) when DataDog and Sentry are enabled.
-   Fixed display of video nodes in document history
-   Fixed members can now create templates again
-   Fixed viewing public shares failed if user has an expired token in outline/outline#6134
-   Restored ability to comment in code blocks in outline/outline#6154
-   Comment functionality should not show in toolbar for view-only users in outline/outline#6011
-   Added support for tldraw snapshot links in outline/outline#6210
-   Restored PWA install in recent Chrome versions
-   Fixed extra empty page in HTML exports in outline/outline#6205
-   Emoji in template titles are now applied correctly in outline/outline#6169
-   Many dependency updates

#### New Contributors

-   [@&#8203;NextFire](https://github.com/NextFire) made their first contribution in outline/outline#6134
-   [@&#8203;EspadaV8](https://github.com/EspadaV8) made their first contribution in outline/outline#6217
-   [@&#8203;RayYH](https://github.com/RayYH) made their first contribution in outline/outline#6238

**Full Changelog**: outline/outline@v0.73.1...v0.74.0

</details>

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Reviewed-on: https://gitea.bui.services/calvinbui/ansible-monorepo/pulls/2031
Co-authored-by: renovate <renovate@noreply.gitea.bui.services>
Co-committed-by: renovate <renovate@noreply.gitea.bui.services>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants