Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser ignoring responses #9

Closed
sheinfeld opened this issue Oct 22, 2020 · 13 comments
Closed

Parser ignoring responses #9

sheinfeld opened this issue Oct 22, 2020 · 13 comments

Comments

@sheinfeld
Copy link

Good afternoon, first of all let me thank you for this amazing package!

I am trying to add the responses to the documentation, but once generated I only get the default 200 and nothing else.

/** * @response 200 { * "status": "success", * "message": "Your request was successfully created" * } * * @response 500 { * "status": "error", * "message": ["Custom error message"] * } */

Do I need to add/change anything?

@makeroi
Copy link

makeroi commented Mar 30, 2021

I have the same problem, I take material from the documentation, but any responses other than 200 are not displayed

@sheinfeld
Copy link
Author

@RodionovSlsUp I just managed to fix some of it, you'll now be able to render multiple responses: sheinfeld/idoc

My next step will be to render the response data parameters like the body ones: https://i.imgur.com/BGQRj3K.png

Stay tuned

@sheinfeld
Copy link
Author

Also just updated the core JS library to it's latest version, looks way better!

@makeroi
Copy link

makeroi commented Mar 30, 2021

Снимок экрана 2021-03-30 в 23 10 51

@sheinfeld in fact, I did about the same thing myself :)

There are very few response fields, it's true

@makeroi
Copy link

makeroi commented Mar 30, 2021

@sheinfeld
Thomas, tell me, is it possible to use your fork through the composer?
And also, is there an understanding, in terms of time, when it will be possible to make the response fields?

Thank you very much, you are cool

@sheinfeld
Copy link
Author

sheinfeld commented Mar 30, 2021 via email

@makeroi
Copy link

makeroi commented Mar 30, 2021

@sheinfeld
Thank you very much, if it's not difficult to call me, mark or write to the mail v.rodionov@sls-up.ru

@makeroi
Copy link

makeroi commented Mar 30, 2021

@sheinfeld by the way, your 500 error is marked as a success. I have not figured out how to elegantly solve this problem and moved the blanks with an error to the config. And I draw the name according to the code from the config.You can see examples in the screenshot

@sheinfeld
Copy link
Author

@RodionovSlsUp I'm looking at it now :D

@sheinfeld
Copy link
Author

@RodionovSlsUp just commit into my forked rep a solution!

I am working on this now:

image

@ronaldwanink
Copy link

@ovac will this be merged back into your repo? Thanks for the hard work btw.. idoc is appreciated very much over here!

@ronaldwanink
Copy link

ronaldwanink commented Oct 12, 2021

BTW, this issue is blocking the phpunit tests driven by hotmeteor/spectator.. if that would work its a great combination.
Ofcourse I can check out @sheinfeld 's repo, but I prefer the composer approach , so I'd rather not.

@ovac
Copy link
Owner

ovac commented Oct 15, 2021

@ronaldwanink, Thank you very much for your kind comment. I will be merging the feature with the next release. I however will want all tests to run successfully though.

@ovac ovac closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants