depedency missing #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oserban
requested review from
senakafdo,
DavidAkroyd,
davidbirchwork,
jamesscottbrown and
miguems
senakafdo
requested changes
Dec 6, 2018
packages/ove-core/package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "express-ws": "4.0.0", | |||
| "http-status-codes": "1.3.0", | |||
| "request": "2.88.0", | |||
| "source-map": "^0.7.3", | |||
There was a problem hiding this comment.
Renovate does not like '^' as it manages the versions.
Suggested change
| "source-map": "^0.7.3", | |
| "source-map": "0.7.3", |
|
@oserban, while investigating further, it seems that there is an issue with uglify-js which is being resolved by this tweak. However, OVE code does not use source-map, so I'm wondering whether the issue was down to some other external factor, which is now masked by this fix? |
senakafdo
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build requested on the install repo