Smart contract actions separate from click handler #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
Explicitly pass dependencies to nodes, so this way we dont need this abstraction registry which is a bit confusing to parse and would not be generic friendly (#1) Moved everything into workspaces. Created an editor workspace added empty contract and tests (#2) Editor flow (#3) * imported flow editor code. working on integrating it into the workspace. need to update to use the new api * show editor and preview side by side * have editor side by side * have editor properly rendering next to scene and we can orbit :) Editor alters scene (#5) * Render scene with spinning suzanne working nicely * have scene working * fix overflow issue * fixed controls color * can pause and resume * can select node from dropdown :) Update README.md Update README.md Update README.md Enabled minting ui (#7) * Clicking works Figured out how to add clicks! Had to pass 'async" to true and evaluate on startup! * simplified to juist clisk * Code cleanup from before * Can click to change! need a second output for it to work * cleaned up ui * got test running * wrote first test * can now have token gated actions. lets publish it! * wip on rainbow and clearing out js files * fix build * Added rainbow kit button * can mint token * saving and loading world works :) Fix smart contracts in space (#8) * emitting the count * got smart contracts working!!!, it fires and subscribes from thepage ;) * styled some nav and pages fixing main removing node thing remove jest click to animate can now be synced thanks toa number fix click to animate elim consoel.log update readme and simplify click to animate simplified readme fixed bugs around loading color, and loading from ipfs added animated building color moved framework into packages/framework. using preconstruct to build now Can now build the editor easily with: yarn install yarn build-editor update readme and fix logo
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
spinning suzanne is the default updated readme fix some readme added unregister (#1) Smart contract actions separate from click handler (#2) * wip on gate node * fix a type * wip on token gating * created mock smart contract actions for this * can now commit and load smart contract actions successfully * made the new thing main thing is now spinning suzanne. copied updated script; Support enabling animations, switch json paths to use indeces instead of names (#7) * nice click to animate demo * better dropdown options * use json paths for numbers * Can now toggle on/off animations * Animations work. Default demo clicks to start the elevator * enabled changed to playing for animation. better code around animations state * cant get thing to stop animating Update README.md fixed playing/paused Better modal - split view changes. (#8) * made the ui splittable * Can change view to be vertical or horizontal * allowing to upload model and set json. now its time for example pairs :) * added example pairs * have gltf properly now stored as one thing * wip on nav * added mint dialog, which saves to ipfs and then mints world with that token * worked on modal but cannot center using flowbite. will try tailwind ui * incorporate tailwind ui for modal. a lot cleaner now! * mint dialog now shows interacitve scene, with proper status * showing nice status when minting * nice styling of the modal. all thats left is the nav! * better modal. switch to hash router so works on ipfs fix title Simpler hooks (#9) * Refactored to use cleaner hooks with more separation. for some reason animation wont play * Fixed animations - by not creating glb twice. Using react-suspense to make sure values always exist * some cleanup - fix so that its all the same * Re-integrated smart contract actions * fixed smart contract actions
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
Explicitly pass dependencies to nodes, so this way we dont need this abstraction registry which is a bit confusing to parse and would not be generic friendly (#1) Moved everything into workspaces. Created an editor workspace added empty contract and tests (#2) Editor flow (#3) * imported flow editor code. working on integrating it into the workspace. need to update to use the new api * show editor and preview side by side * have editor side by side * have editor properly rendering next to scene and we can orbit :) Editor alters scene (#5) * Render scene with spinning suzanne working nicely * have scene working * fix overflow issue * fixed controls color * can pause and resume * can select node from dropdown :) Update README.md Update README.md Update README.md Enabled minting ui (#7) * Clicking works Figured out how to add clicks! Had to pass 'async" to true and evaluate on startup! * simplified to juist clisk * Code cleanup from before * Can click to change! need a second output for it to work * cleaned up ui * got test running * wrote first test * can now have token gated actions. lets publish it! * wip on rainbow and clearing out js files * fix build * Added rainbow kit button * can mint token * saving and loading world works :) Fix smart contracts in space (#8) * emitting the count * got smart contracts working!!!, it fires and subscribes from thepage ;) * styled some nav and pages fixing main removing node thing remove jest click to animate can now be synced thanks toa number fix click to animate elim consoel.log update readme and simplify click to animate simplified readme fixed bugs around loading color, and loading from ipfs added animated building color moved framework into packages/framework. using preconstruct to build now Can now build the editor easily with: yarn install yarn build-editor update readme and fix logo
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
Explicitly pass dependencies to nodes, so this way we dont need this abstraction registry which is a bit confusing to parse and would not be generic friendly (#1) Moved everything into workspaces. Created an editor workspace added empty contract and tests (#2) Editor flow (#3) * imported flow editor code. working on integrating it into the workspace. need to update to use the new api * show editor and preview side by side * have editor side by side * have editor properly rendering next to scene and we can orbit :) Editor alters scene (#5) * Render scene with spinning suzanne working nicely * have scene working * fix overflow issue * fixed controls color * can pause and resume * can select node from dropdown :) Update README.md Update README.md Update README.md Enabled minting ui (#7) * Clicking works Figured out how to add clicks! Had to pass 'async" to true and evaluate on startup! * simplified to juist clisk * Code cleanup from before * Can click to change! need a second output for it to work * cleaned up ui * got test running * wrote first test * can now have token gated actions. lets publish it! * wip on rainbow and clearing out js files * fix build * Added rainbow kit button * can mint token * saving and loading world works :) Fix smart contracts in space (#8) * emitting the count * got smart contracts working!!!, it fires and subscribes from thepage ;) * styled some nav and pages fixing main removing node thing remove jest click to animate can now be synced thanks toa number fix click to animate elim consoel.log update readme and simplify click to animate simplified readme fixed bugs around loading color, and loading from ipfs added animated building color moved framework into packages/framework. using preconstruct to build now Can now build the editor easily with: yarn install yarn build-editor update readme and fix logo
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
Explicitly pass dependencies to nodes, so this way we dont need this abstraction registry which is a bit confusing to parse and would not be generic friendly (#1) Moved everything into workspaces. Created an editor workspace added empty contract and tests (#2) Editor flow (#3) * imported flow editor code. working on integrating it into the workspace. need to update to use the new api * show editor and preview side by side * have editor side by side * have editor properly rendering next to scene and we can orbit :) Editor alters scene (#5) * Render scene with spinning suzanne working nicely * have scene working * fix overflow issue * fixed controls color * can pause and resume * can select node from dropdown :) Update README.md Update README.md Update README.md Enabled minting ui (#7) * Clicking works Figured out how to add clicks! Had to pass 'async" to true and evaluate on startup! * simplified to juist clisk * Code cleanup from before * Can click to change! need a second output for it to work * cleaned up ui * got test running * wrote first test * can now have token gated actions. lets publish it! * wip on rainbow and clearing out js files * fix build * Added rainbow kit button * can mint token * saving and loading world works :) Fix smart contracts in space (#8) * emitting the count * got smart contracts working!!!, it fires and subscribes from thepage ;) * styled some nav and pages fixing main removing node thing remove jest click to animate can now be synced thanks toa number fix click to animate elim consoel.log update readme and simplify click to animate simplified readme fixed bugs around loading color, and loading from ipfs added animated building color moved framework into packages/framework. using preconstruct to build now Can now build the editor easily with: yarn install yarn build-editor update readme and fix logo
oveddan
added a commit
that referenced
this pull request
Nov 25, 2022
spinning suzanne is the default updated readme fix some readme added unregister (#1) Smart contract actions separate from click handler (#2) * wip on gate node * fix a type * wip on token gating * created mock smart contract actions for this * can now commit and load smart contract actions successfully * made the new thing main thing is now spinning suzanne. copied updated script; Support enabling animations, switch json paths to use indeces instead of names (#7) * nice click to animate demo * better dropdown options * use json paths for numbers * Can now toggle on/off animations * Animations work. Default demo clicks to start the elevator * enabled changed to playing for animation. better code around animations state * cant get thing to stop animating Update README.md fixed playing/paused Better modal - split view changes. (#8) * made the ui splittable * Can change view to be vertical or horizontal * allowing to upload model and set json. now its time for example pairs :) * added example pairs * have gltf properly now stored as one thing * wip on nav * added mint dialog, which saves to ipfs and then mints world with that token * worked on modal but cannot center using flowbite. will try tailwind ui * incorporate tailwind ui for modal. a lot cleaner now! * mint dialog now shows interacitve scene, with proper status * showing nice status when minting * nice styling of the modal. all thats left is the nav! * better modal. switch to hash router so works on ipfs fix title Simpler hooks (#9) * Refactored to use cleaner hooks with more separation. for some reason animation wont play * Fixed animations - by not creating glb twice. Using react-suspense to make sure values always exist * some cleanup - fix so that its all the same * Re-integrated smart contract actions * fixed smart contract actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new nodes for invoking and subscribing to smart contract actions; these are no longer bundled with the scene click.
Upgrades to the latest behave-graph and uses their
Graphconcept