Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another go at fixing the failing sockets test #11244

Closed
wants to merge 3 commits into from
Closed

Conversation

gvilums
Copy link
Contributor

@gvilums gvilums commented May 22, 2024

What does this PR do?

Changes the leak test in socket.test.ts to establish connections sequentially instead of in parallel, ensuring it doesn't run into connection limits.

How did you verify your code works?

I'm waiting for CI to see if it's fixed

Copy link
Contributor

github-actions bot commented May 22, 2024

@gvilums, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/node/tls/node-tls-context.test.ts 1 failing

💻 2 failing tests Darwin x64

  • test/cli/install/bun-create.test.ts 2 failing
  • test/cli/install/registry/bun-install-registry.test.ts 3 failing

🪟💻 7 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/js/bun/shell/bunshell.test.ts 1 failing
  • test/js/node/dns/node-dns.test.js 2 failing
  • test/js/node/http/node-http.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts SIGKILL

🪟💻 13 failing tests Windows x64

  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/migration/migrate.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 2 failing
  • test/integration/esbuild/esbuild.test.ts 1 failing
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing
  • test/js/bun/shell/bunshell.test.ts 1 failing
  • test/js/node/dns/node-dns.test.js 2 failing
  • test/js/node/http/node-http.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing
  • test/js/web/fetch/fetch.tls.test.ts 1 failing

View logs

@gvilums gvilums closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant