[install] use default URL when only auth token is specified #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would default to `http://localhost/` which was inconsistent with the case sans token. Use official `npm` registry as fallback in both cases.
alexlamsl
commented
Dec 26, 2022
| \\ Packages: {d} | ||
| \\ Versions: {d} | ||
| \\ External: {d} | ||
| \\ Packages: {d} |
There was a problem hiding this comment.
Apologies for these unrelated whitespace changes 😓
| token: string = "", | ||
| auth: string = "", | ||
|
|
||
| pub const DefaultURL = "https://registry.npmjs.org/"; |
There was a problem hiding this comment.
for zig, the convention is usually:
- primitive types are snake_case
- Types are PascalCase
- functions are camelCase
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would default to
http://localhost/which was inconsistent with the case sans token.Use official
npmregistry as fallback in both cases.