[install] improve package.json validation
#2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexlamsl
commented
Feb 14, 2023
alexlamsl
commented
- report error and exit gracefully instead of crashing
src/install/lockfile.zig
Outdated
| @@ -2677,6 +2677,7 @@ pub const Package = extern struct { | |||
| total_dependencies_count += @truncate(u32, arr.items.len); | |||
| }, | |||
| .e_object => |obj| { | |||
| if (group.behavior.isWorkspace()) return error.InvalidPackageJSON; | |||
There was a problem hiding this comment.
maybe this should have a more specific error
workspaces must be an array of package name strings, like
"workspaces": [ "./folder/package-name", "./folder/package2" ]
| @@ -2691,7 +2692,7 @@ pub const Package = extern struct { | |||
| } | |||
| total_dependencies_count += @truncate(u32, obj.properties.len); | |||
| }, | |||
| else => {}, | |||
There was a problem hiding this comment.
if you do peerDependencies: false or whatever we can just ignore it IMO
- report error and exit gracefully instead of crashing
alexlamsl
force-pushed
the
invalid-package-json
branch
from
a70d0e0
to
6164cd6
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.