fix(dns) Fix resolve4 and resolve6 behavior #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
changed the title
src/bun.js/node-dns.exports.js
Outdated
| @@ -535,15 +548,21 @@ export const promises = { | |||
| } | |||
|
|
|||
| resolve(hostname, rrtype) { | |||
| return dns.resolve(hostname, rrtype).then(promisifyResolve); | |||
| return dns.resolve(hostname, rrtype).then(promisifyResolve(rrtype)); | |||
There was a problem hiding this comment.
can we generate each of these functions at the top somewhere to avoid the extra function allocation
There was a problem hiding this comment.
done in 9aeb64f
src/bun.js/node-dns.exports.js
Outdated
| if (options?.ttl) { | ||
| return dns.lookup(hostname, { family: 4 }); | ||
| } | ||
| return dns.lookup(hostname, { family: 4 }).then((res)=> res?.map(a => a.address)) |
There was a problem hiding this comment.
can we generate each function at the top to avoid the allocation
also make sure you have Prettier configured to run on save (you might need to run bun install somewhere)
There was a problem hiding this comment.
done in 9aeb64f
|
Thank you |
cirospaciari
added a commit
that referenced
this pull request
Feb 27, 2023
* fix #2098 * fix last promisifyResolve call * avoid some functions alloc on dns.exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2098