More bug fixes #2486
Merged
More bug fixes #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
commented
Mar 25, 2023
Jarred-Sumner
commented
Mar 25, 2023
| @@ -2146,7 +2146,7 @@ pub fn escapeHTMLForLatin1Input(allocator: std.mem.Allocator, latin1: []const u8 | |||
|
|
|||
| buf = try std.ArrayList(u8).initCapacity(allocator, latin1.len + @as(usize, Scalar.lengths[c])); | |||
| const copy_len = @ptrToInt(ptr) - @ptrToInt(latin1.ptr); | |||
| @memcpy(buf.items.ptr, latin1.ptr, copy_len - 1); | |||
| @memcpy(buf.items.ptr, latin1.ptr, copy_len); | |||
There was a problem hiding this comment.
pointer arithmetic is tricky
|
❌ @dylan-conway 6 files with test failures on linux-x64:
|
|
❌ @dylan-conway 5 files with test failures on linux-x64-baseline:
|
|
❌ @dylan-conway 10 files with test failures on bun-darwin-x64-baseline:
|
cirospaciari
pushed a commit
that referenced
this pull request
Mar 31, 2023
* readline_promises test fix * fix `escapeHTML` for baseline builds * fs test fixes, use `tmpdir()` * add paths for `resolve.test.js` * isError with toString symbol and error prototype * comment about `toString` * skip async macro transform * test cleanup, skip stack format test * readline undo and redo fix * capture error from readline keypress * Update tcp-server.test.ts * use `removefileat` for recursive rmdir * use strong for `signal.reason` * initialize `m_flags` * directory with file fs test * recursive option * import expect * could be less than * move abort signal tests to another process * fix typecheck --------- Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.