Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun Test matchers even/odd. Also, .toContains fix and truthy #2754

Merged
merged 5 commits into from
May 1, 2023

Conversation

will-richards-ii
Copy link
Contributor

Adds odd/even matchers.

  • failing tests with boilerplate
  • passing tests implementation
    Fixes .toContain in the case of an empty string.
    A few extra truthy test cases.

@Jarred-Sumner
Copy link
Collaborator

Did you run make codegen? There should be changes to a couple generated files due to this. Otherwise, these functions would never be called.

@will-richards-ii
Copy link
Contributor Author

My bad. I did on my local, but did not think to include them in the commit. I should have looked at existing commits more closely. Also ran the ts and zig fmt commands.

@Jarred-Sumner Jarred-Sumner merged commit 59b3556 into oven-sh:main May 1, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants