Updated react example template #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnRG
suggested changes
Jul 12, 2022
|
@rubinj30 Looks like you may have commit changes to packages/bun-landing. I don't think this is necessary. |
FinnRG
suggested changes
Jul 14, 2022
Done. Sorry about the delay on that. |
FinnRG
approved these changes
Jul 15, 2022
|
LGTM, thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the React template to be more inline with the most recent version of create-react-app's default template, including:
reactandreact-dom, and made necessary usage updateseslintConfig, sincejestis no longer in the templatereportWebVitalsto be more inline with most recent version ofcreate-react-app