-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated react example template #627
Conversation
@rubinj30 Looks like you may have commit changes to packages/bun-landing. I don't think this is necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo your changes to packages/bun-landing/bun.lockb
and packages/bun-landing/public/index.html
Done. Sorry about the delay on that. |
LGTM, thank you for your work. |
I updated the React template to be more inline with the most recent version of create-react-app's default template, including:
react
andreact-dom
, and made necessary usage updateseslintConfig
, sincejest
is no longer in the templatereportWebVitals
to be more inline with most recent version ofcreate-react-app