Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL.canParse.length #9710

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix URL.canParse.length #9710

merged 3 commits into from
Mar 29, 2024

Conversation

PondWader
Copy link
Contributor

What does this PR do?

Fixes #9250

URL.canParse.length should be 1:
image

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@PondWader PondWader changed the title Fix url can parse length Fix URL.canParse.length Mar 29, 2024
@jdalton
Copy link
Contributor

jdalton commented Mar 29, 2024

Thank you @PondWader!

@Jarred-Sumner Jarred-Sumner merged commit 9ecb691 into oven-sh:main Mar 29, 2024
24 of 30 checks passed
zloirock added a commit to zloirock/core-js that referenced this pull request Apr 1, 2024
@zloirock
URL.canParse fixed and marked as supported from Bun 1.1.0
589342c 
oven-sh/bun#9710
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@dariosalvi78 dariosalvi78 mentioned this pull request May 19, 2024
Merged
@cb-sl cb-sl mentioned this pull request May 20, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request May 20, 2024
Open
@vinit-aikido vinit-aikido mentioned this pull request May 20, 2024
Open
@Shimizu-Kanaden-sys Shimizu-Kanaden-sys mentioned this pull request May 20, 2024
Open
@olokotoh olokotoh mentioned this pull request May 21, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@AndrzejSmrokowski AndrzejSmrokowski mentioned this pull request May 22, 2024
Open
@marekful marekful mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@patrick-zvenyika patrick-zvenyika mentioned this pull request May 23, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@JosanaDH JosanaDH mentioned this pull request May 24, 2024
Open
@samul-1 samul-1 mentioned this pull request May 24, 2024
Open
@Kypaku Kypaku mentioned this pull request May 24, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@S0nG0ku0 S0nG0ku0 mentioned this pull request May 25, 2024
Open
@fiftysixkbit fiftysixkbit mentioned this pull request Jun 5, 2024
Open
@S0nG0ku0 S0nG0ku0 mentioned this pull request Jun 6, 2024
Open
@castle2668 castle2668 mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Open
Open
@adoliner1 adoliner1 mentioned this pull request Jun 6, 2024
Open
@b34c0n5 b34c0n5 mentioned this pull request Jun 7, 2024
Merged
@TheAutisticTechie TheAutisticTechie mentioned this pull request Jun 7, 2024
Open
@bsimmons123 bsimmons123 mentioned this pull request Jun 10, 2024
Merged
@SarmadBytes SarmadBytes mentioned this pull request Jun 10, 2024
Open
@docker-mobile docker-mobile mentioned this pull request Jun 10, 2024
Open
@jeffplata jeffplata mentioned this pull request Jun 11, 2024
Open
@AbakpaDominic AbakpaDominic mentioned this pull request Jun 11, 2024
Open
@sctlee sctlee mentioned this pull request Jun 11, 2024
Open
@LLotme LLotme mentioned this pull request Jun 11, 2024
Open
@jozsef-armin-hamos jozsef-armin-hamos mentioned this pull request Jun 12, 2024
Open
@samul-1 samul-1 mentioned this pull request Jun 12, 2024
Open
@densbozz densbozz mentioned this pull request Jun 13, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 13, 2024
Open
@vtutors2 vtutors2 mentioned this pull request Jun 14, 2024
Open
@David-Besse David-Besse mentioned this pull request Jun 15, 2024
Merged
@larkinwang20 larkinwang20 mentioned this pull request Jun 15, 2024
Open
@dariosalvi78 dariosalvi78 mentioned this pull request Jun 15, 2024
Merged
@keiserjb keiserjb mentioned this pull request Jun 18, 2024
Open
@alfonsserra alfonsserra mentioned this pull request Jun 20, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jun 20, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jun 20, 2024
Open
@nirw-snyk nirw-snyk mentioned this pull request Jun 21, 2024
Open
@josesnyk josesnyk mentioned this pull request Jun 21, 2024
Open
@jqpe jqpe mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalton jdalton jdalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL.canParse.length should be 1
3 participants
@PondWader @jdalton @Jarred-Sumner