Add apollo upload server supports #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
apollo-upload-server-complient
branch
from
ac1478e
to
5db0c3f
Compare
mcg-web
force-pushed
the
apollo-upload-server-complient
branch
5 times, most recently
from
cda4298
to
78c88ca
Compare
mcg-web
force-pushed
the
apollo-upload-server-complient
branch
from
78c88ca
to
002d0f1
Compare
barduck007
approved these changes
Feb 1, 2018
ooflorent
previously requested changes
Feb 2, 2018
Request/BatchParser.php
Outdated
| @@ -49,17 +51,29 @@ public function parse(Request $request) | |||
| */ | |||
| private function getParsedBody(Request $request) | |||
| { | |||
| $type = explode(';', $request->headers->get('content-type'))[0]; | |||
| $contentType = explode(';', $request->headers->get('content-type'))[0]; | |||
Definition/Type/CustomScalarType.php
Outdated
| { | ||
| if (isset($this->config['scalarType'])) { | ||
| $scalarType = $this->config['scalarType']; | ||
| $scalarType = is_callable($scalarType) ? $scalarType() : $scalarType; |
There was a problem hiding this comment.
Why do you reassign $scalarType?
There was a problem hiding this comment.
Because we also allow lazy loading of the scalarType config entry.
Request/UploadParserTrait.php
Outdated
| return isset($payload['operations']) && isset($payload['map']) && is_array($payload['operations']) && is_array($payload['map']); | ||
| } | ||
|
|
||
| protected function treatUploadFiles(array $parsedBody, array $files) |
There was a problem hiding this comment.
Rename into handleUploadedFiles
Request/UploadParserTrait.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| protected function mappingUploadFiles(array $operations, array $map, array $files) |
There was a problem hiding this comment.
Rename into bindUploadedFiles
mcg-web
force-pushed
the
apollo-upload-server-complient
branch
from
e24f44a
to
94202e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this bundle request parser complient with jaydenseric/graphql-multipart-request-spec.
Unfortunately Ecodev/graphql-upload does not supports
php < 7.1.