feat: Add push and pull options for the android-app image #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Jun 30, 2022
regisb
requested changes
Jul 4, 2022
regisb
requested changes
Jul 29, 2022
|
@angonz did you see my comments above? |
|
Hi! Yes, I'm sorry I didn't have time to make the changes yet. |
|
@angonz will you have time to make the changes in time for Olive? |
|
Hi @regisb, sorry for the delay. I have made the suggested changes and tested in my k8s site. Images build and push correctly, and the app.apk can be downloaded (although I have not tested it) |
regisb
approved these changes
Nov 24, 2022
regisb
reviewed
Nov 24, 2022
angonz
force-pushed
the
angonz/push-app-images
branch
4 times, most recently
from
3cbe923
to
443ac70
Compare
… android-app image.
angonz
force-pushed
the
angonz/push-app-images
branch
from
443ac70
to
4f79a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
tutor images pushandtutor images pushoptions for the android-app image.