Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion notification emails are not being sent #439

Closed
regisb opened this issue May 21, 2021 · 1 comment
Closed

Discussion notification emails are not being sent #439

regisb opened this issue May 21, 2021 · 1 comment
Labels
bug Bugs will be investigated and fixed as quickly as possible.

Comments

@regisb
Copy link
Contributor

regisb commented May 21, 2021

Bug description

See description here: https://discuss.overhang.io/t/does-tutor-support-ace/1451/3?u=regis

When answering a forum conversation in the LMS, users should receive email notifications (provided the feature is enabled). This is not the case: the email sending task is processed by celery, but the SMTP server does not receive any request.

How to reproduce

  1. Enable forum notifications (instructions) by adding {"enable_forum_notifications":true} to the site configuration.
  2. Make a comment in a forum
  3. With a different user, write a reply to the initial comment.

A notification email should be sent, but it's not the case.

To debug this issue, it is recommended to run the LMS without workers (CELERY_ALWAYS_EAGER = True).
@regisb regisb added the bug Bugs will be investigated and fixed as quickly as possible. label May 21, 2021
@pcliupc
Copy link
Contributor

pcliupc commented May 25, 2021 •
edited

In my environment, I found settings.ACE_ROUTING_KEY was set to 'edx.core.low', that's the reason why the send mail task is never consumed.

After setting ACE_ROUTING_KEY to "edx.lms.core.default" in lms.env.json, the email notification works. @regisb

@regisb regisb mentioned this issue May 25, 2021
Merged
pcliupc added a commit to pcliupc/tutor that referenced this issue May 25, 2021
@pcliupc
fix: discussion email notification not work.
8dd451c 
Discussion email notification relies on edx_ace and celery routing
key for ace is not set properly by default, which causes the send
mail task is never consumed.

Close overhangio#439.
@regisb regisb closed this as completed in 58c77ad May 25, 2021
@regisb regisb mentioned this issue May 25, 2021
Merged
cdeery pushed a commit to regisb/edx-platform that referenced this issue Jun 1, 2022
@regisb @cdeery
refactor: less confusing ACE configuration
3dba8a7 
The ACE_* settings from lms/envs/common.py are all ignored because they are
overloaded by the plugin settings. We were recently bitten by this, as we
discovered that the ACE_ROUTING_KEY was incorrectly set to 'edx.core.low'.
Here, we fix this default value and remove ACE_* settings from
lms/envs/common.py to avoid confusion.

See: overhangio/tutor#439
cdeery pushed a commit to openedx/edx-platform that referenced this issue Jun 2, 2022
@regisb
refactor: less confusing ACE configuration (#27719)
7d45438 
The ACE_* settings from lms/envs/common.py are all ignored because they are
overloaded by the plugin settings. We were recently bitten by this, as we
discovered that the ACE_ROUTING_KEY was incorrectly set to 'edx.core.low'.
Here, we fix this default value and remove ACE_* settings from
lms/envs/common.py to avoid confusion.

See: overhangio/tutor#439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs will be investigated and fixed as quickly as possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@regisb @pcliupc