Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.1.6 release appears to have broken contrib plugins #943

Closed
fghaas opened this issue Nov 17, 2023 · 3 comments
Closed

16.1.6 release appears to have broken contrib plugins #943

fghaas opened this issue Nov 17, 2023 · 3 comments
Assignees
Labels
bug Bugs will be investigated and fixed as quickly as possible.

Comments

@fghaas
Copy link
Contributor

fghaas commented Nov 17, 2023

Bug description

Bumping the dependency on tutor to >=16.1.6 in our retirement contrib plugin (see hastexo/tutor-contrib-retirement#27) breaks our build:

py38: install_package_deps> python -I -m pip install 'tutor<17,>=16.1.6'
Collecting tutor<17,>=16.1.6
  Downloading tutor-16.1.6.tar.gz (117 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 117.1/117.1 kB 4.3 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
py38: exit 1 (2.88 seconds) /home/runner/work/tutor-contrib-retirement/tutor-contrib-retirement> python -I -m pip install 'tutor<17,>=16.1.6' pid=2003
.pkg: _exit> python /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
py38: FAIL ✖ in 6.26 seconds
flake8: install_deps> python -I -m pip install flake8
flake8: freeze> python -m pip freeze --all
flake8: flake8==6.1.0,mccabe==0.7.0,pip==23.3.1,pycodestyle==2.11.1,pyflakes==3.1.0,setuptools==68.2.2,wheel==0.41.2
tox: flake8
  gitlint: OK (3.06=setup[2.94]+cmd[0.12] seconds)
  py38: FAIL code 1 (6.26 seconds)
  
  flake8: OK (2.13=setup[1.87]+cmd[0.26] seconds)
  evaluation failed :( (11.53 seconds)
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "/home/runner/work/tutor-contrib-retirement/tutor-contrib-retirement/.tox/py38/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/runner/work/tutor-contrib-retirement/tutor-contrib-retirement/.tox/py38/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/runner/work/tutor-contrib-retirement/tutor-contrib-retirement/.tox/py38/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-0fdttx2a/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-0fdttx2a/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-0fdttx2a/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 507, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-0fdttx2a/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 341, in run_setup
          exec(code, locals())
        File "<string>", line 62, in <module>
        File "<string>", line 29, in load_requirements
      FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-0ea_1nlb/tutor_41909c4854ad4354a9f1d9de33aba6bc/requirements/dev.txt'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

Looks like that dev.txt file didn't make it into the tutor package as published on PyPI.

See the full build log for further context.

How to reproduce

git clone https://github.com/fghaas/tutor-contrib-retirement/tree/palm.4
cd tutor-contrib-retirement
tox -r
@regisb regisb self-assigned this Nov 17, 2023
@regisb regisb added the bug Bugs will be investigated and fixed as quickly as possible. label Nov 17, 2023
@regisb
Copy link
Contributor

regisb commented Nov 17, 2023

Thank you so much for raising this issue quickly Florian. I'll publish 16.1.7 right away.

@sambapete
Copy link

sambapete commented Nov 17, 2023

It's probably related but I have a similar issue trying to install tutor with pip install "tutor[full]==16.1.6"

$ pip install "tutor[full]==16.1.6"
Defaulting to user installation because normal site-packages is not writeable
Collecting tutor==16.1.6 (from tutor[full]==16.1.6)
  Using cached tutor-16.1.6.tar.gz (117 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "/home/ubuntu/.local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/ubuntu/.local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/ubuntu/.local/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-0h6yk9ty/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-0h6yk9ty/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 325, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-0h6yk9ty/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 507, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-0h6yk9ty/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 341, in run_setup
          exec(code, locals())
        File "<string>", line 62, in <module>
        File "<string>", line 29, in load_requirements
      FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-3u7odm0a/tutor_8df43a09d48d4b37b44e5789099670af/requirements/dev.txt'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

@regisb regisb closed this as completed in 66fce06 Nov 17, 2023
moonesque pushed a commit to edSPIRIT/tutor that referenced this issue Nov 20, 2023
fghaas added a commit to fghaas/tutor-contrib-retirement that referenced this issue Nov 20, 2023
We rely on the Tutor OPENEDX_COMMON_VERSION variable to determine
the tag (or branch) to fetch for the Tubular repository.

In Tutor 16.1.6, the default value for OPENEDX_COMMON_VERSION changed
from open-release/palm.3 to open-release/palm.4. This means we now
need a version bump in our own install_requires list, so that we
require Tutor>=16.1.6.

However, the Tutor 16.1.6 package as published to PyPI contains a bug
that makes it uninstallable, so we have to require Tutor>=16.1.7
instead.

References:
https://github.com/overhangio/tutor/releases/tag/v16.1.6
overhangio/tutor#943
@fghaas
Copy link
Contributor Author

fghaas commented Nov 20, 2023

Thanks @regisb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs will be investigated and fixed as quickly as possible.
Projects
Development

No branches or pull requests

3 participants