fix: empty entrypoints in docker-compose=2.0.0.beta4 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
regisb/simplify-mysql-job-definition
branch
2 times, most recently
from
a7d0627
to
055c5ac
Compare
|
This is ready for review @overhangio/tutor-developers. |
An issue with the latest release of docker-compose was reported here: https://discuss.overhang.io/t/undefined-entrypoint-throws-error-in-docker-compose-2-0-0-beta-4/1716 The mysql-job definition had an empty entrypoint (`[]`). This was causing the following error: the initiation of mysql fails with “services.mysql-job.entrypoint must be a string … Error: Command failed with status 15” I can't remember at all why we had to define an empty entrypoint. It probably has to do with the fact that we could not run `sh -e -c "..."` commands in mysql jobs. Similarly, the k8s job definition sets `command: []`. I tested both local and k8s deployments without these definitions and they work just fine. So I guess we can get rid of them.
regisb
force-pushed
the
regisb/simplify-mysql-job-definition
branch
from
055c5ac
to
94bbb8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue with the latest release of docker-compose was reported here:
https://discuss.overhang.io/t/undefined-entrypoint-throws-error-in-docker-compose-2-0-0-beta-4/1716
The mysql-job definition had an empty entrypoint (
[]). This was causing the following error:I can't remember at all why we had to define an empty entrypoint. It probably
has to do with the fact that we could not run
sh -e -c "..."commands inmysql jobs. Similarly, the k8s job definition sets
command: []. I tested bothlocal and k8s deployments without these definitions and they work just fine. So
I guess we can get rid of them.