Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nightly package version #618

Merged
merged 1 commit into from Mar 29, 2022
Merged

fix: nightly package version #618

merged 1 commit into from Mar 29, 2022

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Mar 24, 2022

The version of the nightly python package should not include the "-nightly"
suffix. That's because when we pip install -e tutor plugins, pip also
installs the latest tutor release, as part of the requirements. This overrides
the local (nightly) installation of tutor.

See: https://app.slack.com/client/T02SNA1T6/C02V3GHE3UP

@regisb
Copy link
Contributor Author

regisb commented Mar 24, 2022

cc @kdmccormick

Copy link
Collaborator

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with __version_suffix__ = "nightly". Was able to install tutor-discovery without uninstalling my local Tutor clone 👍🏻

Just one non-blocking suggestion for a comment.

setup.py Outdated Show resolved Hide resolved
The version of the nightly python package should not include the "-nightly"
suffix. That's because when we `pip install -e` tutor plugins, pip also
installs the latest tutor release, as part of the requirements. This overrides
the local (nightly) installation of tutor.

See: https://app.slack.com/client/T02SNA1T6/C02V3GHE3UP
@regisb regisb force-pushed the regisb/fix-nightly-version branch from 43be0bc to 28116a0 Compare March 29, 2022 06:46
@regisb regisb merged commit fa32269 into master Mar 29, 2022
@regisb regisb deleted the regisb/fix-nightly-version branch March 29, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants