build: NIGHTLY ONLY: install nightly branches of official plugins #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@regisb This one's ready for review! |
kdmccormick
force-pushed
the
kdmccormick/nightly-plugins
branch
from
29e9e58
to
05ffadf
Compare
kdmccormick
changed the title
For Tutor Nightly (and only Nightly), official plugins are now installed
from their nightly branches on GitHub instead of a version range on
PyPI. This will allow Nightly users to install all official plugins by
running:
pip install -e ".[full]"
Notes:
* We use the syntax `EGG @ git+REPO@nightly` because the
more common syntax of `git+REPO@nightly#egg=EGG` does not work
when supplied to setup.py's extras_require.
* Unlike other plugins, tutor-license is still installed from PyPI,
but without any version constraint. This is because tutor-license
is a simple, closed-source plugin which activates Wizard edition
for subscribers. It should be available in Nightly but doesn't
need to be installed from its own bleeding-edge branch.
* Unlike most nightly commits, this commit should NOT ever be
reflected on master. When it comes time to merge nightly into
master during the release of Nutmeg, this commit will need to
be manually reverted from master.
* Documentation updates have been made separately so that they
can be merged into master.
kdmccormick
force-pushed
the
kdmccormick/nightly-plugins
branch
from
05ffadf
to
c6a3e61
Compare
kdmccormick
changed the title
kdmccormick
added a commit
to kdmccormick/tutor
that referenced
this pull request
Apr 8, 2022
The full installation will include all the plugins that come bundled with Tutor stable. This is made possible by a recent change to Tutor Nightly (overhangio#626).
regisb
approved these changes
Apr 11, 2022
regisb
pushed a commit
that referenced
this pull request
Apr 15, 2022
The full installation will include all the plugins that come bundled with Tutor stable. This is made possible by a recent change to Tutor Nightly (#626).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes openedx-unsupported/wg-developer-experience#41. Before this PR, Tutor Nightly users needed to install all the official plugins by hand (unlike Tutor Stable users, who have the plugins bundled in for them). After this PR, simply running
pip install -e "./tutor[full]"on the nightly branch will install Tutor Nightly as well as Nightly versions of all pluginsDocumentation changes have been made in a separate PR, so that they can be merged to
masterand reflected on the official documentation site as soon as this is merged tonightly: #631Testing
From Tutor's
nightlybranch:Notes
A couple questions for you @regisb . From the first commit's message:
This ^ is just my best guess on how tutor-license should be installed for Nightly. Let me know if I should do something differently.
Do I have this right?