feat: auto-mount edx-platform python requirements #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
from
1c95606
to
4f9beab
Compare
kdmccormick
requested changes
Oct 16, 2023
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
2 times, most recently
from
0a8e824
to
5a0d29c
Compare
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
from
5a0d29c
to
df7227d
Compare
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
from
df7227d
to
654e1c8
Compare
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
4 times, most recently
from
4b6c323
to
c0ff761
Compare
|
I feel like the current implementation has now reached a decent state, and I'd like to merge this now, such that Palm users can use that feature in the future. I know it's a bit of a rush, but Quince is scheduled for tomorrow... |
These changes make to possible to run:
tutor mounts add /path/to/my-xblock
The xblock directory with then be auto-magically bind-mounted in the
"openedx" image at build time, and the lms*/cms* containers at run time.
This makes it effectively possible to work as a developer on
edx-platform requirements.
We take the opportunity to move some openedx-specific code to a
dedicated module.
Close openedx-unsupported/wg-developer-experience#177
regisb
force-pushed
the
regisb/mount-edx-platform-packages
branch
from
c0ff761
to
88b299e
Compare
|
Hi @regisb, this will be a great for developers, thank you! But I tried using this on my |
|
@pomegranited what repos did you try to mount? Did the mount fail at build or run-time? |
|
@regisb My apologies -- I re-read your updated dev docs and found my error: I missed that tutor dev uses the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make to possible to run:
The xblock directory with then be auto-magically bind-mounted in the "openedx" image at build time, and the lms*/cms* containers at run time.
This makes it effectively possible to work as a developer on edx-platform requirements.
We take the opportunity to move some openedx-specific code to a dedicated module.
Close openedx-unsupported/wg-developer-experience#177