Build with crash reporting against Sentry #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGro
requested changes
Jun 6, 2023
JulianGro
added
the
server
JulianGro
reviewed
Jun 8, 2023
|
So on the server side of things this doesn't do anything yet because there's no server-side crash reporting. But I plan to add it in a future PR, and the environment vars won't hurt. |
JulianGro
approved these changes
Jun 11, 2023
| @@ -210,7 +210,14 @@ jobs: | |||
| - name: Configure CMake | |||
| working-directory: build | |||
| shell: bash | |||
| run: cmake .. -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DVCPKG_BUILD_TYPE=release $CMAKE_EXTRA | |||
| run: | | |||
| if [ -z "$CMAKE_BACKTRACE_URL" ] ; then | |||
There was a problem hiding this comment.
I think it would be nicer to check again something like on.pull_request, but I have no idea how to do that so this will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Sentry token so that we can report crashes.
This should be handy for the new release which includes large code changes.